From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69335 invoked by alias); 13 Sep 2018 15:57:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69320 invoked by uid 89); 13 Sep 2018 15:57:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=comply X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Sep 2018 15:57:17 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w8DFvA2b012758 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 13 Sep 2018 11:57:15 -0400 Received: by simark.ca (Postfix, from userid 112) id 653C21E75F; Thu, 13 Sep 2018 11:57:10 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 179E01E16B; Thu, 13 Sep 2018 11:57:09 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 13 Sep 2018 15:57:00 -0000 From: Simon Marchi To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org, eliz@gnu.org Subject: Re: [PATCH v2, doc] python: Provide textual representation for Inferior and Objfile In-Reply-To: <87d0thqxas.fsf@tromey.com> References: <20180912225001.8701-1-simon.marchi@ericsson.com> <87d0thqxas.fsf@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00428.txt.bz2 On 2018-09-13 10:36, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> +gdb_test "python print (inferiors)" "\\( pid=$decimal>,\\)" "verify inferiors list" > > Some of the new test lines run over 80 characters. Most of them are easy enough to make fit in 80 chars, but one is still over, because it has a long match pattern string. My understanding was that we were a bit more lenient on the line length for those gdb_test lines (splitting the patterns just to comply to that rule would just make them less readable). > Other than that nit the patch looks good to me. Thanks, I pushed it with those fixed as much as I can. I also addressed Eli's comment about repr() and str(). Simon