From: Doug Evans <dje@google.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: FYI: fix PR 11345
Date: Thu, 04 Mar 2010 17:28:00 -0000 [thread overview]
Message-ID: <e394668d1003040928ke49c7f2hc70e915ce82f2d42@mail.gmail.com> (raw)
In-Reply-To: <201003041720.47722.pedro@codesourcery.com>
On Thu, Mar 4, 2010 at 9:20 AM, Pedro Alves <pedro@codesourcery.com> wrote:
> Eh, I didn't realize that -Wformat-nonliteral should be of
> for this file. I now see the sneaky sed above. That changes
> perpective.
>
>>
>> Could you try Doug's suggestion?
>>
>> printf_filtered (last_arg, 0);
>>
>> If that doesn't work I will write a loop using strstr.
>
> It works for me, indeed. But didn't Doug say it didn't
> for him?
>
> On Thursday 04 March 2010 02:56:39, Doug Evans wrote:
>> ... but having tried it I'm seeing "... argument types not checked".
>> Blech.
I was explicitly turning on the warning.
If we adopt the rule that this file can't be compiled with that
warning, that's different.
next prev parent reply other threads:[~2010-03-04 17:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 18:04 Tom Tromey
2010-03-03 18:22 ` Tom Tromey
2010-03-04 0:47 ` Pedro Alves
2010-03-04 2:35 ` Doug Evans
2010-03-04 2:43 ` Pedro Alves
2010-03-04 2:56 ` Doug Evans
2010-03-04 3:01 ` Pedro Alves
2010-03-04 2:36 ` Tom Tromey
2010-03-04 17:01 ` Tom Tromey
2010-03-04 17:20 ` Pedro Alves
2010-03-04 17:28 ` Doug Evans [this message]
2010-03-04 18:21 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e394668d1003040928ke49c7f2hc70e915ce82f2d42@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox