From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70748-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30532 invoked by alias); 4 Mar 2010 17:28:51 -0000
Received: (qmail 30519 invoked by uid 22791); 4 Mar 2010 17:28:49 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Mar 2010 17:28:44 +0000
Received: from wpaz9.hot.corp.google.com (wpaz9.hot.corp.google.com [172.24.198.73]) 	by smtp-out.google.com with ESMTP id o24HSg7h005463 	for <gdb-patches@sourceware.org>; Thu, 4 Mar 2010 09:28:42 -0800
Received: from wwa36 (wwa36.prod.google.com [10.241.241.36]) 	by wpaz9.hot.corp.google.com with ESMTP id o24HSeDa025560 	for <gdb-patches@sourceware.org>; Thu, 4 Mar 2010 09:28:41 -0800
Received: by wwa36 with SMTP id 36so1552986wwa.19         for <gdb-patches@sourceware.org>; Thu, 04 Mar 2010 09:28:40 -0800 (PST)
MIME-Version: 1.0
Received: by 10.216.88.207 with SMTP id a57mr73970wef.200.1267723719875; Thu,  	04 Mar 2010 09:28:39 -0800 (PST)
In-Reply-To: <201003041720.47722.pedro@codesourcery.com>
References: <m3mxyp703n.fsf@fleche.redhat.com> 	 <201003040047.17716.pedro@codesourcery.com> 	 <m38wa82f9m.fsf@fleche.redhat.com> 	 <201003041720.47722.pedro@codesourcery.com>
Date: Thu, 04 Mar 2010 17:28:00 -0000
Message-ID: <e394668d1003040928ke49c7f2hc70e915ce82f2d42@mail.gmail.com>
Subject: Re: FYI: fix PR 11345
From: Doug Evans <dje@google.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-03/txt/msg00193.txt.bz2

On Thu, Mar 4, 2010 at 9:20 AM, Pedro Alves <pedro@codesourcery.com> wrote:
> Eh, I didn't realize that -Wformat-nonliteral should be of
> for this file. =A0I now see the sneaky sed above. =A0That changes
> perpective.
>
>>
>> Could you try Doug's suggestion?
>>
>> =A0 =A0 printf_filtered (last_arg, 0);
>>
>> If that doesn't work I will write a loop using strstr.
>
> It works for me, indeed. =A0But didn't Doug say it didn't
> for him?
>
> On Thursday 04 March 2010 02:56:39, Doug Evans wrote:
>> ... but having tried it I'm seeing "... argument types not checked".
>> Blech.

I was explicitly turning on the warning.
If we adopt the rule that this file can't be compiled with that
warning, that's different.