Re: FYI: fix PR 11345

[Pedro Alves <pedro@codesourcery.com>]

On Wednesday 03 March 2010 18:04:44, Tom Tromey wrote:
> -    /* Print the portion of the format string after the last argument.  */
> -    puts_filtered (last_arg);
> +    /* Print the portion of the format string after the last argument.
> +       Note that this will not include any ordinary %-specs, but it
> +       might include "%%".  That is why we use printf_filtered and not
> +       puts_filtered here.  */
> +    printf_filtered (last_arg);

This causes:

make[1]: Leaving directory `/home/pedro/gdb/baseline/build/gdb'
gcc -g3 -O0   -I. -I../../src/gdb -I../../src/gdb/common -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber  -I../../src/gdb/gnulib -Ignulib  -DMI_OUT=1 -DTUI=1   `echo " -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts " | sed "s/ -Wformat-nonliteral / /g"` \
                -Werror -c -o printcmd.o -MT printcmd.o -MMD -MP -MF .deps/printcmd.Tpo ../../src/gdb/printcmd.c
cc1: warnings being treated as errors
../../src/gdb/printcmd.c: In function 'printf_command':
../../src/gdb/printcmd.c:2649: error: format not a string literal and no format arguments
make: *** [printcmd.o] Error 1

Guess the original bug needs fixing in a different way.  :-/

-- 
Pedro Alves