From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17451 invoked by alias); 4 Mar 2010 00:47:24 -0000 Received: (qmail 17442 invoked by uid 22791); 4 Mar 2010 00:47:24 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Mar 2010 00:47:21 +0000 Received: (qmail 12576 invoked from network); 4 Mar 2010 00:47:19 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 4 Mar 2010 00:47:19 -0000 From: Pedro Alves To: gdb-patches@sourceware.org, tromey@redhat.com Subject: Re: FYI: fix PR 11345 Date: Thu, 04 Mar 2010 00:47:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-19-generic; KDE/4.3.2; x86_64; ; ) References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201003040047.17716.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00142.txt.bz2 On Wednesday 03 March 2010 18:04:44, Tom Tromey wrote: > - /* Print the portion of the format string after the last argument. */ > - puts_filtered (last_arg); > + /* Print the portion of the format string after the last argument. > + Note that this will not include any ordinary %-specs, but it > + might include "%%". That is why we use printf_filtered and not > + puts_filtered here. */ > + printf_filtered (last_arg); This causes: make[1]: Leaving directory `/home/pedro/gdb/baseline/build/gdb' gcc -g3 -O0 -I. -I../../src/gdb -I../../src/gdb/common -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber -I../../src/gdb/gnulib -Ignulib -DMI_OUT=1 -DTUI=1 `echo " -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts " | sed "s/ -Wformat-nonliteral / /g"` \ -Werror -c -o printcmd.o -MT printcmd.o -MMD -MP -MF .deps/printcmd.Tpo ../../src/gdb/printcmd.c cc1: warnings being treated as errors ../../src/gdb/printcmd.c: In function 'printf_command': ../../src/gdb/printcmd.c:2649: error: format not a string literal and no format arguments make: *** [printcmd.o] Error 1 Guess the original bug needs fixing in a different way. :-/ -- Pedro Alves