From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix parallel gdb/ make check//% site.exp
Date: Mon, 09 Nov 2009 16:38:00 -0000 [thread overview]
Message-ID: <e394668d0911090838p7c80b22ch3019c811db1d9b5f@mail.gmail.com> (raw)
In-Reply-To: <20091109121507.GA9438@host0.dyn.jankratochvil.net>
On Mon, Nov 9, 2009 at 4:15 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> Hi,
>
> sometimes `make check//unix/-m32' just did not produce any results.
>
> Caught it is due to site.exp existing in gdb/testsuite/ thus satisfying VPATH
> make dependency on it but runtest does not execute anything without site.exp
> file in its current directory.
>
>
> Regards,
> Jan
>
>
> gdb/testsuite/
> 2009-11-09 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * Makefile.in (check-single, $(TEST_TARGETS), check-gdb.base%): Change
> `site.exp' dependency to `./site.exp'.
>
> --- gdb/testsuite/Makefile.in 19 Oct 2009 09:51:43 -0000 1.28
> +++ gdb/testsuite/Makefile.in 9 Nov 2009 12:12:52 -0000
> @@ -147,7 +147,7 @@ DO_RUNTEST = \
> export TCL_LIBRARY ; fi ; \
> $(RUNTEST)
>
> -check-single: all site.exp
> +check-single: all ./site.exp
> $(DO_RUNTEST) $(RUNTESTFLAGS)
>
> # A list of all directories named "gdb.*" which also hold a .exp file.
> @@ -170,7 +170,7 @@ check-parallel:
> $(SHELL) $(srcdir)/dg-extract-results.sh -L \
> $(addsuffix /gdb.log,$(TEST_DIRS)) > gdb.log
>
> -$(filter-out check-gdb.base%,$(TEST_TARGETS)): check-gdb.%: all site.exp
> +$(filter-out check-gdb.base%,$(TEST_TARGETS)): check-gdb.%: all ./site.exp
> @if test ! -d gdb.$*; then mkdir gdb.$*; fi
> $(DO_RUNTEST) --directory=gdb.$* --outdir=gdb.$* $(RUNTESTFLAGS)
>
> @@ -179,7 +179,7 @@ BASE1_FILES = $(patsubst $(srcdir)/%,%,$
> BASE2_FILES = $(patsubst $(srcdir)/%,%,$(wildcard $(srcdir)/gdb.base/[n-z]*.exp))
>
> # Handle each half of gdb.base.
> -check-gdb.base%: all site.exp
> +check-gdb.base%: all ./site.exp
> @if test ! -d gdb.base$*; then mkdir gdb.base$*; fi
> $(DO_RUNTEST) $(BASE$*_FILES) --outdir gdb.base$* $(RUNTESTFLAGS)
>
I'll defer to Tom on whether this is a fix,
but if the patch does go in, I'd like to see comments added to the
code explaining why things are the way they are.
site vs ./site.exp seems fairly subtle.
prev parent reply other threads:[~2009-11-09 16:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 12:15 Jan Kratochvil
2009-11-09 15:37 ` Tom Tromey
2009-11-09 17:20 ` Jan Kratochvil
2009-11-09 17:32 ` Tom Tromey
2009-11-09 18:00 ` Jan Kratochvil
2009-11-09 17:33 ` Doug Evans
2009-11-09 17:50 ` Jan Kratochvil
2009-11-09 17:53 ` Daniel Jacobowitz
2009-11-09 16:38 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e394668d0911090838p7c80b22ch3019c811db1d9b5f@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox