From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28464 invoked by alias); 9 Nov 2009 16:38:17 -0000 Received: (qmail 28453 invoked by uid 22791); 9 Nov 2009 16:38:16 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Nov 2009 16:38:10 +0000 Received: from spaceape13.eur.corp.google.com (spaceape13.eur.corp.google.com [172.28.16.147]) by smtp-out.google.com with ESMTP id nA9Gc7dg025757 for ; Mon, 9 Nov 2009 08:38:08 -0800 Received: from ewy6 (ewy6.prod.google.com [10.241.103.6]) by spaceape13.eur.corp.google.com with ESMTP id nA9Gc4DU031968 for ; Mon, 9 Nov 2009 08:38:05 -0800 Received: by ewy6 with SMTP id 6so3381540ewy.6 for ; Mon, 09 Nov 2009 08:38:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.93.1 with SMTP id k1mr367498wef.151.1257784684236; Mon, 09 Nov 2009 08:38:04 -0800 (PST) In-Reply-To: <20091109121507.GA9438@host0.dyn.jankratochvil.net> References: <20091109121507.GA9438@host0.dyn.jankratochvil.net> Date: Mon, 09 Nov 2009 16:38:00 -0000 Message-ID: Subject: Re: [patch] Fix parallel gdb/ make check//% site.exp From: Doug Evans To: Jan Kratochvil Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00140.txt.bz2 On Mon, Nov 9, 2009 at 4:15 AM, Jan Kratochvil wrote: > Hi, > > sometimes `make check//unix/-m32' just did not produce any results. > > Caught it is due to site.exp existing in gdb/testsuite/ thus satisfying V= PATH > make dependency on it but runtest does not execute anything without site.= exp > file in its current directory. > > > Regards, > Jan > > > gdb/testsuite/ > 2009-11-09 =A0Jan Kratochvil =A0 > > =A0 =A0 =A0 =A0* Makefile.in (check-single, $(TEST_TARGETS), check-gdb.ba= se%): Change > =A0 =A0 =A0 =A0`site.exp' dependency to `./site.exp'. > > --- gdb/testsuite/Makefile.in =A0 19 Oct 2009 09:51:43 -0000 =A0 =A0 =A01= .28 > +++ gdb/testsuite/Makefile.in =A0 9 Nov 2009 12:12:52 -0000 > @@ -147,7 +147,7 @@ DO_RUNTEST =3D \ > =A0 =A0 =A0 =A0 =A0export TCL_LIBRARY ; fi ; \ > =A0 =A0 =A0 =A0$(RUNTEST) > > -check-single: all site.exp > +check-single: all ./site.exp > =A0 =A0 =A0 =A0$(DO_RUNTEST) $(RUNTESTFLAGS) > > =A0# A list of all directories named "gdb.*" which also hold a .exp file. > @@ -170,7 +170,7 @@ check-parallel: > =A0 =A0 =A0 =A0$(SHELL) $(srcdir)/dg-extract-results.sh -L \ > =A0 =A0 =A0 =A0 =A0$(addsuffix /gdb.log,$(TEST_DIRS)) > gdb.log > > -$(filter-out check-gdb.base%,$(TEST_TARGETS)): check-gdb.%: all site.exp > +$(filter-out check-gdb.base%,$(TEST_TARGETS)): check-gdb.%: all ./site.e= xp > =A0 =A0 =A0 =A0@if test ! -d gdb.$*; then mkdir gdb.$*; fi > =A0 =A0 =A0 =A0$(DO_RUNTEST) --directory=3Dgdb.$* --outdir=3Dgdb.$* $(RUN= TESTFLAGS) > > @@ -179,7 +179,7 @@ BASE1_FILES =3D $(patsubst $(srcdir)/%,%,$ > =A0BASE2_FILES =3D $(patsubst $(srcdir)/%,%,$(wildcard $(srcdir)/gdb.base= /[n-z]*.exp)) > > =A0# Handle each half of gdb.base. > -check-gdb.base%: all site.exp > +check-gdb.base%: all ./site.exp > =A0 =A0 =A0 =A0@if test ! -d gdb.base$*; then mkdir gdb.base$*; fi > =A0 =A0 =A0 =A0$(DO_RUNTEST) $(BASE$*_FILES) --outdir gdb.base$* $(RUNTES= TFLAGS) > I'll defer to Tom on whether this is a fix, but if the patch does go in, I'd like to see comments added to the code explaining why things are the way they are. site vs ./site.exp seems fairly subtle.