Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Joel Sherrill <joel.sherrill@oarcorp.com>,
	        "gdb@sourceware.org" <gdb@sourceware.org>,
	        Ralf Corsepius <ralf.corsepius@rtems.org>,
	gdb-patches@sourceware.org
Subject: Re: SPARC GDB Failure
Date: Mon, 07 Sep 2009 18:16:00 -0000	[thread overview]
Message-ID: <e394668d0909071115p4fa41d15u13db897df9bf351b@mail.gmail.com> (raw)
In-Reply-To: <20090907175406.GA13914@host0.dyn.jankratochvil.net>

On Mon, Sep 7, 2009 at 10:54 AM, Jan
Kratochvil<jan.kratochvil@redhat.com> wrote:
> On Mon, 07 Sep 2009 19:44:03 +0200, Doug Evans wrote:
>> The patch is fine with me.
>
> Checked-in.
> [...]
> http://sourceware.org/ml/gdb-cvs/2009-09/msg00028.html
>
> --- src/gdb/ChangeLog   2009/09/07 11:09:33     1.10846
> +++ src/gdb/ChangeLog   2009/09/07 17:52:38     1.10847
> @@ -1,3 +1,9 @@
> +2009-09-07  Jan Kratochvil  <jan.kratochvil@redhat.com>
> +
> +       * m68k-tdep.c (m68k_gdbarch_init): Allocate TDEP as cleared.
> +       * sparc-tdep.c (sparc32_gdbarch_init): Allocate TDEP as cleared.
> +       Remove explicit clearing of TDEP fields.
> +
> [...]

Long-term-wise, maybe the thing to do is have all allocs of
gdbarch_tdep go through a function (gdbarch_tdep_alloc or some such).
That would make it clear how one *should* alloc them.


  reply	other threads:[~2009-09-07 18:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4AA5161D.1020102@oarcorp.com>
2009-09-07 16:45 ` Jan Kratochvil
2009-09-07 17:44   ` Doug Evans
2009-09-07 17:54     ` Jan Kratochvil
2009-09-07 18:16       ` Doug Evans [this message]
2009-09-07 18:24         ` Joel Brobecker
2009-09-07 18:35         ` Jan Kratochvil
2009-09-07 18:40         ` Joel Sherrill
2009-09-08  6:46           ` Ralf Corsepius

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e394668d0909071115p4fa41d15u13db897df9bf351b@mail.gmail.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gdb@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=joel.sherrill@oarcorp.com \
    --cc=ralf.corsepius@rtems.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox