From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29256 invoked by alias); 7 Sep 2009 18:16:02 -0000 Received: (qmail 29239 invoked by uid 22791); 7 Sep 2009 18:16:02 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Sep 2009 18:15:54 +0000 Received: from zps38.corp.google.com (zps38.corp.google.com [172.25.146.38]) by smtp-out.google.com with ESMTP id n87IFn7g026234; Mon, 7 Sep 2009 19:15:50 +0100 Received: from ywh35 (ywh35.prod.google.com [10.192.8.35]) by zps38.corp.google.com with ESMTP id n87IFkVP009447; Mon, 7 Sep 2009 11:15:47 -0700 Received: by ywh35 with SMTP id 35so2779210ywh.28 for ; Mon, 07 Sep 2009 11:15:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.208.21 with SMTP id f21mr24404401ybg.80.1252347346169; Mon, 07 Sep 2009 11:15:46 -0700 (PDT) In-Reply-To: <20090907175406.GA13914@host0.dyn.jankratochvil.net> References: <4AA5161D.1020102@oarcorp.com> <20090907164528.GA6326@host0.dyn.jankratochvil.net> <20090907175406.GA13914@host0.dyn.jankratochvil.net> Date: Mon, 07 Sep 2009 18:16:00 -0000 Message-ID: Subject: Re: SPARC GDB Failure From: Doug Evans To: Jan Kratochvil Cc: Joel Sherrill , "gdb@sourceware.org" , Ralf Corsepius , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00160.txt.bz2 On Mon, Sep 7, 2009 at 10:54 AM, Jan Kratochvil wrote: > On Mon, 07 Sep 2009 19:44:03 +0200, Doug Evans wrote: >> The patch is fine with me. > > Checked-in. > [...] > http://sourceware.org/ml/gdb-cvs/2009-09/msg00028.html > > --- src/gdb/ChangeLog =A0 2009/09/07 11:09:33 =A0 =A0 1.10846 > +++ src/gdb/ChangeLog =A0 2009/09/07 17:52:38 =A0 =A0 1.10847 > @@ -1,3 +1,9 @@ > +2009-09-07 =A0Jan Kratochvil =A0 > + > + =A0 =A0 =A0 * m68k-tdep.c (m68k_gdbarch_init): Allocate TDEP as cleared. > + =A0 =A0 =A0 * sparc-tdep.c (sparc32_gdbarch_init): Allocate TDEP as cle= ared. > + =A0 =A0 =A0 Remove explicit clearing of TDEP fields. > + > [...] Long-term-wise, maybe the thing to do is have all allocs of gdbarch_tdep go through a function (gdbarch_tdep_alloc or some such). That would make it clear how one *should* alloc them.