Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Joel Sherrill <joel.sherrill@oarcorp.com>,
	        "gdb@sourceware.org" <gdb@sourceware.org>,
	        Ralf Corsepius <ralf.corsepius@rtems.org>,
	gdb-patches@sourceware.org
Subject: Re: SPARC GDB Failure
Date: Mon, 07 Sep 2009 17:54:00 -0000	[thread overview]
Message-ID: <20090907175406.GA13914@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <e394668d0909071044k421712b7q537b1a5170da1e0e@mail.gmail.com>

On Mon, 07 Sep 2009 19:44:03 +0200, Doug Evans wrote:
> The patch is fine with me.

Checked-in.


> I think, though, the changelog shouldn't claim it fixes something
> unless that's been verified.

I agree, fixed.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2009-09/msg00028.html

--- src/gdb/ChangeLog	2009/09/07 11:09:33	1.10846
+++ src/gdb/ChangeLog	2009/09/07 17:52:38	1.10847
@@ -1,3 +1,9 @@
+2009-09-07  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* m68k-tdep.c (m68k_gdbarch_init): Allocate TDEP as cleared.
+	* sparc-tdep.c (sparc32_gdbarch_init): Allocate TDEP as cleared.
+	Remove explicit clearing of TDEP fields.
+
 2009-09-06  Hui Zhu  <teawater@gmail.com>
 
 	* i386-tdep.c (i386_record_check_override): Deleted.
--- src/gdb/m68k-tdep.c	2009/07/02 17:25:55	1.144
+++ src/gdb/m68k-tdep.c	2009/09/07 17:52:41	1.145
@@ -1160,7 +1160,7 @@
       break;
     }
 
-  tdep = xmalloc (sizeof (struct gdbarch_tdep));
+  tdep = xzalloc (sizeof (struct gdbarch_tdep));
   gdbarch = gdbarch_alloc (&info, tdep);
   tdep->fpregs_present = has_fp;
   tdep->flavour = flavour;
--- src/gdb/sparc-tdep.c	2009/07/02 17:25:58	1.208
+++ src/gdb/sparc-tdep.c	2009/09/07 17:52:41	1.209
@@ -1377,16 +1377,11 @@
     return arches->gdbarch;
 
   /* Allocate space for the new architecture.  */
-  tdep = XMALLOC (struct gdbarch_tdep);
+  tdep = XZALLOC (struct gdbarch_tdep);
   gdbarch = gdbarch_alloc (&info, tdep);
 
   tdep->pc_regnum = SPARC32_PC_REGNUM;
   tdep->npc_regnum = SPARC32_NPC_REGNUM;
-  tdep->gregset = NULL;
-  tdep->sizeof_gregset = 0;
-  tdep->fpregset = NULL;
-  tdep->sizeof_fpregset = 0;
-  tdep->plt_entry_size = 0;
   tdep->step_trap = sparc_step_trap;
 
   set_gdbarch_long_double_bit (gdbarch, 128);


  reply	other threads:[~2009-09-07 17:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4AA5161D.1020102@oarcorp.com>
2009-09-07 16:45 ` Jan Kratochvil
2009-09-07 17:44   ` Doug Evans
2009-09-07 17:54     ` Jan Kratochvil [this message]
2009-09-07 18:16       ` Doug Evans
2009-09-07 18:24         ` Joel Brobecker
2009-09-07 18:35         ` Jan Kratochvil
2009-09-07 18:40         ` Joel Sherrill
2009-09-08  6:46           ` Ralf Corsepius

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090907175406.GA13914@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gdb@sourceware.org \
    --cc=joel.sherrill@oarcorp.com \
    --cc=ralf.corsepius@rtems.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox