From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31792 invoked by alias); 7 Sep 2009 17:54:29 -0000 Received: (qmail 31774 invoked by uid 22791); 7 Sep 2009 17:54:28 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Sep 2009 17:54:18 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n87HsGxL028111; Mon, 7 Sep 2009 13:54:16 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n87Hs9XZ014141 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 7 Sep 2009 13:54:14 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n87Hs9wA013988; Mon, 7 Sep 2009 19:54:09 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id n87Hs6oh013983; Mon, 7 Sep 2009 19:54:06 +0200 Date: Mon, 07 Sep 2009 17:54:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: Joel Sherrill , "gdb@sourceware.org" , Ralf Corsepius , gdb-patches@sourceware.org Subject: Re: SPARC GDB Failure Message-ID: <20090907175406.GA13914@host0.dyn.jankratochvil.net> References: <4AA5161D.1020102@oarcorp.com> <20090907164528.GA6326@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00158.txt.bz2 On Mon, 07 Sep 2009 19:44:03 +0200, Doug Evans wrote: > The patch is fine with me. Checked-in. > I think, though, the changelog shouldn't claim it fixes something > unless that's been verified. I agree, fixed. Thanks, Jan http://sourceware.org/ml/gdb-cvs/2009-09/msg00028.html --- src/gdb/ChangeLog 2009/09/07 11:09:33 1.10846 +++ src/gdb/ChangeLog 2009/09/07 17:52:38 1.10847 @@ -1,3 +1,9 @@ +2009-09-07 Jan Kratochvil + + * m68k-tdep.c (m68k_gdbarch_init): Allocate TDEP as cleared. + * sparc-tdep.c (sparc32_gdbarch_init): Allocate TDEP as cleared. + Remove explicit clearing of TDEP fields. + 2009-09-06 Hui Zhu * i386-tdep.c (i386_record_check_override): Deleted. --- src/gdb/m68k-tdep.c 2009/07/02 17:25:55 1.144 +++ src/gdb/m68k-tdep.c 2009/09/07 17:52:41 1.145 @@ -1160,7 +1160,7 @@ break; } - tdep = xmalloc (sizeof (struct gdbarch_tdep)); + tdep = xzalloc (sizeof (struct gdbarch_tdep)); gdbarch = gdbarch_alloc (&info, tdep); tdep->fpregs_present = has_fp; tdep->flavour = flavour; --- src/gdb/sparc-tdep.c 2009/07/02 17:25:58 1.208 +++ src/gdb/sparc-tdep.c 2009/09/07 17:52:41 1.209 @@ -1377,16 +1377,11 @@ return arches->gdbarch; /* Allocate space for the new architecture. */ - tdep = XMALLOC (struct gdbarch_tdep); + tdep = XZALLOC (struct gdbarch_tdep); gdbarch = gdbarch_alloc (&info, tdep); tdep->pc_regnum = SPARC32_PC_REGNUM; tdep->npc_regnum = SPARC32_NPC_REGNUM; - tdep->gregset = NULL; - tdep->sizeof_gregset = 0; - tdep->fpregset = NULL; - tdep->sizeof_fpregset = 0; - tdep->plt_entry_size = 0; tdep->step_trap = sparc_step_trap; set_gdbarch_long_double_bit (gdbarch, 128);