Re: [PATCH 4/7] [gdb] Add block::superblocks

[Tom de Vries <tdevries@suse.de>]

On 4/30/26 6:24 PM, Simon Marchi wrote:
> On 4/23/26 2:35 AM, Tom de Vries wrote:
>> +
>> +    self_type &operator++ ()
>> +    {
>> +      this->m_item = this->m_item->superblock ();
> 
> IMO we don't need to use `this->` on members prefixed with `m_`, because
> it's already clear that they are fields of this class.  I do use
> `this->` on fields that are not prefixed with `m_` though, otherwise
> it's not clear where it comes from.

I've fixed this.

In next_iterator, there was a similar pattern, but I couldn't just drop 
the this prefix.  I managed to fix this by adding "using ...::m_item":
...
template<typename T>
struct next_iterator : base_next_iterator<T, next_iterator<T>>
{
   using base_next_iterator<T, next_iterator<T>>::base_next_iterator;
   using base_next_iterator<T, next_iterator<T>>::m_item;

   T *next ()
   {
     return m_item->next;
   }
};
...

Thanks,
- Tom