Re: [PATCH 5/7] [gdb] Use block::super_blocks

[Tom de Vries <tdevries@suse.de>]

On 4/24/26 6:27 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> Use block::super_blocks in a few locations to simplify code.
> 
> Tom> -    for (const block *b = get_selected_block (0);
> Tom> -	 b != nullptr;
> Tom> -	 b = b->superblock ())
> Tom> +    for (auto b : block::super_blocks (get_selected_block (0)))
> 
> Why not "get_selected_block(0)->super_blocks ()" here?

Because get_selected_block (0) might be nullptr.

I actually checked with an assert:
...
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index 71a338ce17e..76639685977 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -13825,6 +13825,7 @@ class ada_language : public language_defn
      /* Search upwards from currently selected frame (so that we can
         complete on local vars.  */

+    gdb_assert (get_selected_block (0) != nullptr);
      for (const block *b = get_selected_block (0);
  	 b != nullptr;
  	 b = b->superblock ())
...
and it triggers in gdb.dwarf2/ada-cold-name.exp.

Thanks,
- Tom