From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0Z0OOHOo9GnRGwkAWB0awg (envelope-from ) for ; Fri, 01 May 2026 09:19:47 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=OHeWrWjP; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=datG7w3V; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=OHeWrWjP; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=datG7w3V; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E13901E0BA; Fri, 01 May 2026 09:19:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 74D821E067 for ; Fri, 01 May 2026 09:19:47 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 1856C44115CD for ; Fri, 1 May 2026 13:19:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1856C44115CD Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=OHeWrWjP; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=datG7w3V; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=OHeWrWjP; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=datG7w3V Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id EF43C46A9CF8 for ; Fri, 1 May 2026 13:19:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EF43C46A9CF8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EF43C46A9CF8 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777641552; cv=none; b=I5WdsJPsmDUdqb+wIlI9FkadecZxf6V0rngNEM/JzYh1sBTWfOlqQbDptgzIFSsIZRRXeNaQKx8tBiJdc9mLMPzCnoNrWuGB7PYshbypFCSLAI6uEQUF6+1Ihzc9jNPRcCJTro33h+5ATdynBAc+CiLT+RaM71SAwgllAZnk2Jc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777641552; c=relaxed/simple; bh=/cuCiywtg4bkunjohRrI0u0uXjZxUAGaZZg11yKd0F4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=o1U6l8hnsq9OupLBgx3ahCHVqbXbJpBecHG3xrjehVaA/9yShOqGleMVJl14dUS8Hofzj/MvWI6lSgj4yTyiTFtBmdbhzVFJl6K3Vt3s8kI64Clsdti+Yry7VbbAqiXrH4XZ/p2Oynkexj+VjGDC60Ph+FMWtR4xi0VXG6mDc3E= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EF43C46A9CF8 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A1A746A88B; Fri, 1 May 2026 13:19:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777641550; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PckPW15daCS1SvbmYMLsoENPEJh+cn1ni4wHG2pG+zs=; b=OHeWrWjPObcbuj3C+KxRPD/iOLayyicnVBVYpha5xCxGJftBjRGqm/bRPfkG9wWJXTyAqG G2VcgSr9+pLDDzFVsSyniI8o3tVEf+HVv/+GDeCnhQY8OY8I3XhsmvkE3mr0GSppdMPayQ tNxTT9FaH2BO6mehh7YFZH6HBvITXRQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777641550; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PckPW15daCS1SvbmYMLsoENPEJh+cn1ni4wHG2pG+zs=; b=datG7w3VVmvd3jy0SrVQedy21wlJbVdqR0N2a78RaGoJnYQyVgS1I+IheUVJT0CGFevMH/ ftnCcFnaVO8/9LDg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OHeWrWjP; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=datG7w3V DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777641550; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PckPW15daCS1SvbmYMLsoENPEJh+cn1ni4wHG2pG+zs=; b=OHeWrWjPObcbuj3C+KxRPD/iOLayyicnVBVYpha5xCxGJftBjRGqm/bRPfkG9wWJXTyAqG G2VcgSr9+pLDDzFVsSyniI8o3tVEf+HVv/+GDeCnhQY8OY8I3XhsmvkE3mr0GSppdMPayQ tNxTT9FaH2BO6mehh7YFZH6HBvITXRQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777641550; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PckPW15daCS1SvbmYMLsoENPEJh+cn1ni4wHG2pG+zs=; b=datG7w3VVmvd3jy0SrVQedy21wlJbVdqR0N2a78RaGoJnYQyVgS1I+IheUVJT0CGFevMH/ ftnCcFnaVO8/9LDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 89029593B0; Fri, 1 May 2026 13:19:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 3O2AH06o9GlACQAAD6G6ig (envelope-from ); Fri, 01 May 2026 13:19:10 +0000 Message-ID: Date: Fri, 1 May 2026 15:19:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/7] [gdb] Add block::superblocks To: Simon Marchi , gdb-patches@sourceware.org References: <20260423063530.1074175-1-tdevries@suse.de> <20260423063530.1074175-5-tdevries@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; RCPT_COUNT_TWO(0.00)[2]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: A1A746A88B X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/30/26 6:24 PM, Simon Marchi wrote: > On 4/23/26 2:35 AM, Tom de Vries wrote: >> + >> + self_type &operator++ () >> + { >> + this->m_item = this->m_item->superblock (); > > IMO we don't need to use `this->` on members prefixed with `m_`, because > it's already clear that they are fields of this class. I do use > `this->` on fields that are not prefixed with `m_` though, otherwise > it's not clear where it comes from. I've fixed this. In next_iterator, there was a similar pattern, but I couldn't just drop the this prefix. I managed to fix this by adding "using ...::m_item": ... template struct next_iterator : base_next_iterator> { using base_next_iterator>::base_next_iterator; using base_next_iterator>::m_item; T *next () { return m_item->next; } }; ... Thanks, - Tom