From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Deduplicate require_running macros and move them up
Date: Fri, 15 Sep 2017 14:13:00 -0000 [thread overview]
Message-ID: <dd0d5796-fcaa-7572-5432-42fedcc2a945@redhat.com> (raw)
In-Reply-To: <1505482514-10206-1-git-send-email-simon.marchi@ericsson.com>
On 09/15/2017 02:35 PM, Simon Marchi wrote:
> I find it very confusing to define the require_running in the middle of
> the file, and re-define it to something else later in the middle of the
> same file. I think it would be better if those macros had different
> names so that we know exactly what they do.
Indeed. Looks good to me.
Thanks,
Pedro Alves
prev parent reply other threads:[~2017-09-15 14:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 13:35 Simon Marchi
2017-09-15 13:35 ` [PATCH 2/2] gdbserver: Move detach code to its own function Simon Marchi
2017-09-15 13:39 ` Simon Marchi
2017-09-15 14:13 ` Pedro Alves
2017-09-15 16:01 ` Simon Marchi
2017-09-15 14:13 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd0d5796-fcaa-7572-5432-42fedcc2a945@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox