From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94237 invoked by alias); 15 Sep 2017 14:13:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93689 invoked by uid 89); 15 Sep 2017 14:13:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Sep 2017 14:13:46 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DA1594E4C2; Fri, 15 Sep 2017 14:13:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DA1594E4C2 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4452D71CB7; Fri, 15 Sep 2017 14:13:44 +0000 (UTC) Subject: Re: [PATCH 1/2] Deduplicate require_running macros and move them up To: Simon Marchi , gdb-patches@sourceware.org References: <1505482514-10206-1-git-send-email-simon.marchi@ericsson.com> From: Pedro Alves Message-ID: Date: Fri, 15 Sep 2017 14:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1505482514-10206-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00414.txt.bz2 On 09/15/2017 02:35 PM, Simon Marchi wrote: > I find it very confusing to define the require_running in the middle of > the file, and re-define it to something else later in the middle of the > same file. I think it would be better if those macros had different > names so that we know exactly what they do. Indeed. Looks good to me. Thanks, Pedro Alves