From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdbserver: Move detach code to its own function
Date: Fri, 15 Sep 2017 16:01:00 -0000 [thread overview]
Message-ID: <166e6bfd83ad4593df80ad0591dc815a@polymtl.ca> (raw)
In-Reply-To: <eca37e02-fd91-c91b-0bb8-54ef983be38b@redhat.com>
On 2017-09-15 16:12, Pedro Alves wrote:
> On 09/15/2017 02:35 PM, Simon Marchi wrote:
>> }
>>
>> +static void
>> +handle_detach (char *own_buf)
>> +{
>
> Patch looks fine, but could you add some intro comment:
>
> /* Handle the "D" packet. */
Doh, of course. I fixed it and pushed both patches.
Thanks,
Simon
next prev parent reply other threads:[~2017-09-15 16:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 13:35 [PATCH 1/2] Deduplicate require_running macros and move them up Simon Marchi
2017-09-15 13:35 ` [PATCH 2/2] gdbserver: Move detach code to its own function Simon Marchi
2017-09-15 13:39 ` Simon Marchi
2017-09-15 14:13 ` Pedro Alves
2017-09-15 16:01 ` Simon Marchi [this message]
2017-09-15 14:13 ` [PATCH 1/2] Deduplicate require_running macros and move them up Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166e6bfd83ad4593df80ad0591dc815a@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox