From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-141684-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 44316 invoked by alias); 15 Sep 2017 16:01:19 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 43883 invoked by uid 89); 15 Sep 2017 16:01:18 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:377
X-HELO: smtp.polymtl.ca
Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Sep 2017 16:01:16 +0000
Received: from simark.ca (simark.ca [158.69.221.121])	(authenticated bits=0)	by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v8FG1AbL027663	(version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)	for <gdb-patches@sourceware.org>; Fri, 15 Sep 2017 12:01:15 -0400
Received: by simark.ca (Postfix, from userid 112)	id 0F8A81ECF0; Fri, 15 Sep 2017 12:01:10 -0400 (EDT)
Received: from simark.ca (localhost [127.0.0.1])	by simark.ca (Postfix) with ESMTP id 6BCCF1E5B9;	Fri, 15 Sep 2017 12:01:09 -0400 (EDT)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Fri, 15 Sep 2017 16:01:00 -0000
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdbserver: Move detach code to its own function
In-Reply-To: <eca37e02-fd91-c91b-0bb8-54ef983be38b@redhat.com>
References: <1505482514-10206-1-git-send-email-simon.marchi@ericsson.com> <1505482514-10206-2-git-send-email-simon.marchi@ericsson.com> <eca37e02-fd91-c91b-0bb8-54ef983be38b@redhat.com>
Message-ID: <166e6bfd83ad4593df80ad0591dc815a@polymtl.ca>
X-Sender: simon.marchi@polymtl.ca
User-Agent: Roundcube Webmail/1.3.0
X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 15 Sep 2017 16:01:10 +0000
X-IsSubscribed: yes
X-SW-Source: 2017-09/txt/msg00418.txt.bz2

On 2017-09-15 16:12, Pedro Alves wrote:
> On 09/15/2017 02:35 PM, Simon Marchi wrote:
>>  }
>> 
>> +static void
>> +handle_detach (char *own_buf)
>> +{
> 
> Patch looks fine, but could you add some intro comment:
> 
> /* Handle the "D" packet.  */

Doh, of course.  I fixed it and pushed both patches.

Thanks,

Simon