Re: [PATCH] [gdb] Add .shellcheckrc

[Tom de Vries <tdevries@suse.de>]

On 8/31/26 10:05 PM, Simon Marchi wrote:
> On 8/31/26 4:22 AM, Tom de Vries wrote:
>> I came across an inconsistency between shellcheck versions 0.10.0 and 0.11.0.
>>
>> Version v0.11.0 disables SC2002 (Useless use of cat) by default.
>>
>> Fix this inconsistency by enabling it by default in gdb/.shellcheckrc.
>>
>> Add symlinks at {gdbserver,gdbsupport}/.shellcheckrc.
>>
>> These symlinks will be expanded to regular files in the tarballs as produced
>> by src-release.sh due to using "tar -h".
> 
> Approved-By: Simon Marchi <simon.marchi@efficios.com>
> 
> I did not know there were optionl / disabled by default rules.
> 
> https://github.com/koalaman/shellcheck/wiki/Optional
> 
> I think we should look at enabling some of them.
> 

Hi Simon,

thanks for the review, I've pushed this.

I agree we could look into optional rules (perhaps a good moment is once 
all scripts are shellcheck-clean).

FWIW, I wish something opposite to require-variable-braces would be 
available.

Thanks,
- Tom

> Simon