From: Simon Marchi <simark@simark.ca>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb] Add .shellcheckrc
Date: Mon, 31 Aug 2026 16:05:50 -0400 [thread overview]
Message-ID: <6165e6ce-5798-4930-95bc-9d146449d091@simark.ca> (raw)
In-Reply-To: <20260831082201.3507660-1-tdevries@suse.de>
On 8/31/26 4:22 AM, Tom de Vries wrote:
> I came across an inconsistency between shellcheck versions 0.10.0 and 0.11.0.
>
> Version v0.11.0 disables SC2002 (Useless use of cat) by default.
>
> Fix this inconsistency by enabling it by default in gdb/.shellcheckrc.
>
> Add symlinks at {gdbserver,gdbsupport}/.shellcheckrc.
>
> These symlinks will be expanded to regular files in the tarballs as produced
> by src-release.sh due to using "tar -h".
Approved-By: Simon Marchi <simon.marchi@efficios.com>
I did not know there were optionl / disabled by default rules.
https://github.com/koalaman/shellcheck/wiki/Optional
I think we should look at enabling some of them.
Simon
next prev parent reply other threads:[~2026-08-31 20:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 8:22 Tom de Vries
2026-08-31 20:05 ` Simon Marchi [this message]
2026-08-31 23:04 ` Tom de Vries
2026-09-01 16:25 ` Tom Tromey
2026-09-01 16:27 ` Tom de Vries
2026-09-01 21:37 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6165e6ce-5798-4930-95bc-9d146449d091@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox