From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GfOwAp8Ilmrw3hgAWB0awg (envelope-from ) for ; Mon, 31 Aug 2026 19:05:03 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=l90J2IvD; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=tP+SXgzH; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=OTiYSbx+; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ktinmZaH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 02A5A1E166; Mon, 31 Aug 2026 19:05:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A7C951E033 for ; Mon, 31 Aug 2026 19:05:01 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 718F04BA23ED for ; Mon, 31 Aug 2026 23:05:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 718F04BA23ED Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=l90J2IvD; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=tP+SXgzH; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=OTiYSbx+; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ktinmZaH Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 5E3CE4BA2E20 for ; Mon, 31 Aug 2026 23:04:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5E3CE4BA2E20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5E3CE4BA2E20 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788217474; cv=none; b=HSfQtYtHN8GuQpN6hg7cYf7QL1pQ32Dja2fK0qgsXwvPcKLGYnxEidjM1H3Jy5IyA6txIsd8Rln9JzzmtGk1FfuEYOI0vBCk9e5MNWASbzGzB9QY5t2mGJxSc1su7ha2m7hhXa5Jg8yI8XP1cyNGA9GugPuKPu1pyaSnasgPHmY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788217474; c=relaxed/simple; bh=vN9ur+ITi04oigYg7A5ud/y2EMVSZpo77ZGKUzp4IuI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=f7enVvDFsjYCjiLnRtdBhg0gvGnIa9oBLAHZomVgbbsodckI/EksMrfNY3Yhbrtuwmp4Pfx7aW/2alV7CK8qlDB73mdAerBcV04dimLCY8kVUxK3RwTnaxomUMjMQjonj4WWgylhdXL1B7wVLKEmhrIkfGfgs0JT5i+Qr2OtYr8= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=l90J2IvD; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=tP+SXgzH; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=OTiYSbx+; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ktinmZaH DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E3CE4BA2E20 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 451271FB21; Mon, 31 Aug 2026 23:04:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788217468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pg68+8oJOfTLMu9NdJvntFOmNwZVxWvHzwaS9qr2DC4=; b=l90J2IvDKkKO+3F3gs2xuoljOJ0O3CAG9CW7zkvzRZj02r0ecmG9f+T+UEy08VLcm5tSDq 7gfDTTHeh5YIjUZt431A6x/QSKibpid439PyUeKZoeKbjAbtY6W1fQMrljEMFsdls7zsC7 57RKU38oIyFxkVaQ3gVEWVQn61BwYeY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788217468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pg68+8oJOfTLMu9NdJvntFOmNwZVxWvHzwaS9qr2DC4=; b=tP+SXgzHgyAx2/DmuMJ6BzwpHWGt0kD6kAxONA8df3M0jg6gUlPSjsrBA4cIYjreyFcMBz Rp2WbnDYVc2nXpAA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OTiYSbx+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ktinmZaH DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788217464; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pg68+8oJOfTLMu9NdJvntFOmNwZVxWvHzwaS9qr2DC4=; b=OTiYSbx+FMjZE3MuOTFPeepPpV7z9d0eKwdKc9DZoXD97f7LxuvvfytMi+eWCjobtpsLiL sur2NDXNtZoYpMFYZ7taOzGwERZFdfElg9IuJvg5ODpeLzxIm3ML2M6dNmgptapjEfbKlG nfqxVCqEONnpZMTsZ/4Qx4CG2hUTqb4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788217464; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pg68+8oJOfTLMu9NdJvntFOmNwZVxWvHzwaS9qr2DC4=; b=ktinmZaHzAvwp9LZaOTp70cchpcifNmbgsI9dS7QzgEynnbsJkJY9qWAx5foMZAF8FZ1IX +r3Ld3rIlxis0XBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EC8E913515; Mon, 31 Aug 2026 23:04:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VihKM3cIlmoeawAAD6G6ig (envelope-from ); Mon, 31 Aug 2026 23:04:23 +0000 Message-ID: Date: Tue, 1 Sep 2026 01:04:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb] Add .shellcheckrc To: Simon Marchi , gdb-patches@sourceware.org References: <20260831082201.3507660-1-tdevries@suse.de> <6165e6ce-5798-4930-95bc-9d146449d091@simark.ca> Content-Language: en-US From: Tom de Vries In-Reply-To: <6165e6ce-5798-4930-95bc-9d146449d091@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 451271FB21 X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim,suse.de:mid]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/31/26 10:05 PM, Simon Marchi wrote: > On 8/31/26 4:22 AM, Tom de Vries wrote: >> I came across an inconsistency between shellcheck versions 0.10.0 and 0.11.0. >> >> Version v0.11.0 disables SC2002 (Useless use of cat) by default. >> >> Fix this inconsistency by enabling it by default in gdb/.shellcheckrc. >> >> Add symlinks at {gdbserver,gdbsupport}/.shellcheckrc. >> >> These symlinks will be expanded to regular files in the tarballs as produced >> by src-release.sh due to using "tar -h". > > Approved-By: Simon Marchi > > I did not know there were optionl / disabled by default rules. > > https://github.com/koalaman/shellcheck/wiki/Optional > > I think we should look at enabling some of them. > Hi Simon, thanks for the review, I've pushed this. I agree we could look into optional rules (perhaps a good moment is once all scripts are shellcheck-clean). FWIW, I wish something opposite to require-variable-braces would be available. Thanks, - Tom > Simon