From: Pedro Alves <palves@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>,
GDB Patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@polymtl.ca>, John Baldwin <jhb@freebsd.org>
Subject: Re: [PATCH v3 1/2] Introduce "gdb/configure.nat" (and delete "gdb/config/*/*.mh" files)
Date: Fri, 05 May 2017 16:35:00 -0000 [thread overview]
Message-ID: <dbba7539-3f52-bfd3-3f69-8d6d34ac0f36@redhat.com> (raw)
In-Reply-To: <20170505042951.32097-2-sergiodj@redhat.com>
On 05/05/2017 05:29 AM, Sergio Durigan Junior wrote:
> +# Native-target dependent makefile fragment comes in here.
> +@nat_extra_makefile_frag@
> +
> rename from gdb/config/i386/i386gnu.mh
> rename to gdb/config/i386/i386gnu-extra.mh
> index 070497f..93016ff 100644
> --- a/gdb/config/i386/i386gnu.mh
> +++ b/gdb/config/i386/i386gnu-extra.mh
...
> # MIG stubs are not yet ready for C++ compilation.
> -%_S.o %_U.o : COMPILE.post += -x c
> +%_S.o %_U.o : COMPILE.post +=-x c
>
Spurious whitespace change.
> NAT_GENERATED_FILES = notify_S.h notify_S.c \
> - process_reply_S.h process_reply_S.c \
> - msg_reply_S.h msg_reply_S.c msg_U.h msg_U.c \
> - exc_request_U.h exc_request_U.c exc_request_S.h exc_request_S.c
> + process_reply_S.h process_reply_S.c \
> + msg_reply_S.h msg_reply_S.c msg_U.h msg_U.c \
> + exc_request_U.h exc_request_U.c exc_request_S.h exc_request_S.c
Ditto.
Apart from the naming issue and the spurious whitespace changes,
this looks fine to me.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-05-05 16:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 20:23 [PATCH] " Sergio Durigan Junior
2017-04-25 21:08 ` John Baldwin
2017-05-01 18:45 ` Sergio Durigan Junior
2017-05-02 2:44 ` Simon Marchi
2017-05-02 14:57 ` John Baldwin
2017-05-02 17:01 ` Simon Marchi
2017-05-02 19:28 ` Sergio Durigan Junior
2017-05-02 20:16 ` Simon Marchi
2017-05-02 21:30 ` Pedro Alves
2017-05-02 22:17 ` Sergio Durigan Junior
2017-05-03 3:49 ` [PATCH v2 0/2] Introduce gdb/configure.nat Sergio Durigan Junior
2017-05-03 3:49 ` [PATCH v2 1/2] Introduce "gdb/configure.nat" (and delete "gdb/config/*/*.mh" files) Sergio Durigan Junior
2017-05-04 16:16 ` Pedro Alves
2017-05-05 3:58 ` Sergio Durigan Junior
2017-05-05 9:41 ` Pedro Alves
2017-05-06 14:04 ` Sergio Durigan Junior
2017-05-17 14:03 ` Pedro Alves
2017-05-03 3:49 ` [PATCH v2 2/2] Rearrange gdb/configure.nat to make it simpler and less redundant Sergio Durigan Junior
2017-05-03 16:45 ` John Baldwin
2017-05-03 17:28 ` Sergio Durigan Junior
2017-05-04 16:34 ` Pedro Alves
2017-05-05 4:23 ` Sergio Durigan Junior
2017-05-05 4:31 ` [PATCH v3 0/2] Introduce gdb/configure.nat Sergio Durigan Junior
2017-05-05 4:31 ` [PATCH v3 2/2] Rearrange gdb/configure.nat to make it simpler and less redundant Sergio Durigan Junior
2017-05-06 14:13 ` Sergio Durigan Junior
2017-05-05 4:32 ` [PATCH v3 1/2] Introduce "gdb/configure.nat" (and delete "gdb/config/*/*.mh" files) Sergio Durigan Junior
2017-05-05 16:35 ` Pedro Alves [this message]
2017-05-06 14:13 ` Sergio Durigan Junior
2017-05-17 13:22 ` Pedro Alves
2017-05-23 14:40 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbba7539-3f52-bfd3-3f69-8d6d34ac0f36@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@freebsd.org \
--cc=sergiodj@redhat.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox