From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 925 invoked by alias); 5 May 2017 16:35:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 893 invoked by uid 89); 5 May 2017 16:35:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-16.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=Hx-languages-length:1086 X-HELO: mail-wr0-f182.google.com Received: from mail-wr0-f182.google.com (HELO mail-wr0-f182.google.com) (209.85.128.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 05 May 2017 16:35:26 +0000 Received: by mail-wr0-f182.google.com with SMTP id w50so6907926wrc.0 for ; Fri, 05 May 2017 09:35:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=GLkndI6JlL+9K/AafzOpapZlMkpwHof/FtLemTIaXBA=; b=XIB/Qrkn/KXpLOAZtIISKkbsrfb6VCdtSG736w225LQ84S9UqA6PnooKZ4P759TrGj j35Bzgx4J9AI4DwVNaUjB3bujjCHJ7KogLm/b+dkU4/jZoNBsdU/B1Wc6SYEzu0e/qyR 6c2eNWKPCtzkUguFFNowBI/tBx9At7I2are6OivDA3r7p98dvGFXGGQTQjhJhImgSoaM QOmgigsW5En6ZhssLI67+c1l4AsXT+TmiSp0jxBWmzJs3cgLpBaa+xvmejXxphDlNaaq J7djL+STTHpKeDwL3N++fiH3UHpFKHkrFTEwxxMFWjG/V9ASlncbbZujdbq5yI5gpDFV CRjA== X-Gm-Message-State: AN3rC/488NIBV2TmOHuQZPXA38RIQISr60Ro5Dhm5wNgAyoy+IwWSe0q uD91jrlpxC7luBpJT9Lmfg== X-Received: by 10.223.169.226 with SMTP id b89mr30345982wrd.147.1494002127422; Fri, 05 May 2017 09:35:27 -0700 (PDT) Received: from [192.168.0.102] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id x29sm2877510wma.29.2017.05.05.09.35.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 May 2017 09:35:26 -0700 (PDT) Subject: Re: [PATCH v3 1/2] Introduce "gdb/configure.nat" (and delete "gdb/config/*/*.mh" files) To: Sergio Durigan Junior , GDB Patches References: <20170425202309.15771-1-sergiodj@redhat.com> <20170505042951.32097-1-sergiodj@redhat.com> <20170505042951.32097-2-sergiodj@redhat.com> Cc: Simon Marchi , John Baldwin From: Pedro Alves Message-ID: Date: Fri, 05 May 2017 16:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170505042951.32097-2-sergiodj@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-05/txt/msg00148.txt.bz2 On 05/05/2017 05:29 AM, Sergio Durigan Junior wrote: > +# Native-target dependent makefile fragment comes in here. > +@nat_extra_makefile_frag@ > + > rename from gdb/config/i386/i386gnu.mh > rename to gdb/config/i386/i386gnu-extra.mh > index 070497f..93016ff 100644 > --- a/gdb/config/i386/i386gnu.mh > +++ b/gdb/config/i386/i386gnu-extra.mh ... > # MIG stubs are not yet ready for C++ compilation. > -%_S.o %_U.o : COMPILE.post += -x c > +%_S.o %_U.o : COMPILE.post +=-x c > Spurious whitespace change. > NAT_GENERATED_FILES = notify_S.h notify_S.c \ > - process_reply_S.h process_reply_S.c \ > - msg_reply_S.h msg_reply_S.c msg_U.h msg_U.c \ > - exc_request_U.h exc_request_U.c exc_request_S.h exc_request_S.c > + process_reply_S.h process_reply_S.c \ > + msg_reply_S.h msg_reply_S.c msg_U.h msg_U.c \ > + exc_request_U.h exc_request_U.c exc_request_S.h exc_request_S.c Ditto. Apart from the naming issue and the spurious whitespace changes, this looks fine to me. Thanks, Pedro Alves