Re: [commit] multi-executable support

[Hui Zhu <teawater@gmail.com>]

Thanks.

Hui

On Tue, Oct 20, 2009 at 19:20, Pedro Alves <pedro@codesourcery.com> wrote:
> On Tuesday 20 October 2009 07:13:58, Hui Zhu wrote:
>> darwin-nat.c
>>   if (breakpoint_inserted_here_p (pc))
>
> Thanks.  "grep breakpoint_inserted_here_p *nat*" doesn't find
> any other missing adjustment in native target files.  I've no easy way
> to test this, but the needed change is very simple.  Plus, this
> function is a copy of linux-nat.c:cancel_breakpoint, where I did
> the exact same change.
>
> I'm applying this.
>
> 2009-10-20  Pedro Alves  <pedro@codesourcery.com>
>
>        * darwin-nat.c (cancel_breakpoint): Pass the regcache's address
>        space to breakpoint_inserted_here_p.
>
> ---
>  gdb/darwin-nat.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: src/gdb/darwin-nat.c
> ===================================================================
> --- src.orig/gdb/darwin-nat.c   2009-10-20 12:15:12.000000000 +0100
> +++ src/gdb/darwin-nat.c        2009-10-20 12:16:03.000000000 +0100
> @@ -995,7 +995,7 @@ cancel_breakpoint (ptid_t ptid)
>   CORE_ADDR pc;
>
>   pc = regcache_read_pc (regcache) - gdbarch_decr_pc_after_break (gdbarch);
> -  if (breakpoint_inserted_here_p (pc))
> +  if (breakpoint_inserted_here_p (get_regcache_aspace (regcache), pc))
>     {
>       inferior_debug (4, "cancel_breakpoint for thread %x\n",
>                      ptid_get_tid (ptid));
>
>
> --
> Pedro Alves
>