From: Ken Werner <ken@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org, Pedro Alves <pedro@codesourcery.com>
Subject: Re: [commit] multi-executable support
Date: Tue, 20 Oct 2009 15:05:00 -0000 [thread overview]
Message-ID: <200910201504.n9KF4Nnk015902@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <200910191106.28905.pedro@codesourcery.com>
[-- Attachment #1: Type: text/plain, Size: 410 bytes --]
Pedro Alves wrote:
> On Tuesday 13 October 2009 14:40:47, Pedro Alves wrote:
>> ... I'll aim at applying this at the end of the week, say.
>
> Here's the patch that I just committed.
I noticed the gdb/go32-nat.c and gdb/remote-sim.c are calling
inferior_appeared_silent which is not declared by the inferior.h header. It
looks like this is a typo. The attached patch calls inferior_appeared
instead.
-ken
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: inferior_appeared.patch --]
[-- Type: text/x-patch; name="inferior_appeared.patch", Size: 1188 bytes --]
Index: src/gdb/go32-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/go32-nat.c,v
retrieving revision 1.78
diff -u -r1.78 go32-nat.c
--- src/gdb/go32-nat.c 19 Oct 2009 09:51:41 -0000 1.78
+++ src/gdb/go32-nat.c 20 Oct 2009 07:26:33 -0000
@@ -716,7 +716,7 @@
inferior_ptid = pid_to_ptid (SOME_PID);
inf = current_inferior ();
- inferior_appeared_silent (inf, SOME_PID);
+ inferior_appeared (inf, SOME_PID);
push_target (&go32_ops);
Index: src/gdb/remote-sim.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-sim.c,v
retrieving revision 1.91
diff -u -r1.91 remote-sim.c
--- src/gdb/remote-sim.c 19 Oct 2009 09:51:41 -0000 1.91
+++ src/gdb/remote-sim.c 20 Oct 2009 07:26:33 -0000
@@ -471,7 +471,7 @@
sim_create_inferior (gdbsim_desc, exec_bfd, argv, env);
inferior_ptid = remote_sim_ptid;
- inferior_appeared_silent (current_inferior (), ptid_get_pid (inferior_ptid));
+ inferior_appeared (current_inferior (), ptid_get_pid (inferior_ptid));
add_thread_silent (inferior_ptid);
insert_breakpoints (); /* Needed to get correct instruction in cache */
next prev parent reply other threads:[~2009-10-20 15:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200910191106.28905.pedro@codesourcery.com>
2009-10-20 6:14 ` Hui Zhu
2009-10-20 11:20 ` Pedro Alves
2009-10-21 2:18 ` Hui Zhu
2009-10-20 15:05 ` Ken Werner [this message]
2009-10-20 15:36 ` Pedro Alves
2009-10-20 15:54 ` Ken Werner
2009-10-20 16:34 ` Pedro Alves
2009-10-21 8:27 ` Obvious fix: deprecated_insert_raw_breakpoint change (was [commit] multi-executable support) Pierre Muller
2009-10-21 8:40 ` Pedro Alves
2009-11-13 1:09 ` [commit] multi-executable support Paul Pluzhnikov
2009-11-15 22:53 ` Pedro Alves
2009-11-16 18:42 ` Paul Pluzhnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910201504.n9KF4Nnk015902@d06av02.portsmouth.uk.ibm.com \
--to=ken@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox