From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-67865-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7352 invoked by alias); 21 Oct 2009 02:18:46 -0000
Received: (qmail 7342 invoked by uid 22791); 21 Oct 2009 02:18:46 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail-pz0-f192.google.com (HELO mail-pz0-f192.google.com) (209.85.222.192)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Oct 2009 02:18:40 +0000
Received: by pzk30 with SMTP id 30so4901754pzk.24         for <gdb-patches@sourceware.org>; Tue, 20 Oct 2009 19:18:39 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.143.24.36 with SMTP id b36mr493286wfj.14.1256091519077; Tue,  	20 Oct 2009 19:18:39 -0700 (PDT)
In-Reply-To: <200910201220.54860.pedro@codesourcery.com>
References: <200910191106.28905.pedro@codesourcery.com> <daef60380910192313t243b9210w25862c32274ff68a@mail.gmail.com>  	<200910201220.54860.pedro@codesourcery.com>
From: Hui Zhu <teawater@gmail.com>
Date: Wed, 21 Oct 2009 02:18:00 -0000
Message-ID: <daef60380910201918v2053aae2m9fd0bb0a3709b04b@mail.gmail.com>
Subject: Re: [commit] multi-executable support
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-10/txt/msg00488.txt.bz2

Thanks.

Hui

On Tue, Oct 20, 2009 at 19:20, Pedro Alves <pedro@codesourcery.com> wrote:
> On Tuesday 20 October 2009 07:13:58, Hui Zhu wrote:
>> darwin-nat.c
>> =A0 if (breakpoint_inserted_here_p (pc))
>
> Thanks. =A0"grep breakpoint_inserted_here_p *nat*" doesn't find
> any other missing adjustment in native target files. =A0I've no easy way
> to test this, but the needed change is very simple. =A0Plus, this
> function is a copy of linux-nat.c:cancel_breakpoint, where I did
> the exact same change.
>
> I'm applying this.
>
> 2009-10-20 =A0Pedro Alves =A0<pedro@codesourcery.com>
>
> =A0 =A0 =A0 =A0* darwin-nat.c (cancel_breakpoint): Pass the regcache's ad=
dress
> =A0 =A0 =A0 =A0space to breakpoint_inserted_here_p.
>
> ---
> =A0gdb/darwin-nat.c | =A0 =A02 +-
> =A01 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: src/gdb/darwin-nat.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- src.orig/gdb/darwin-nat.c =A0 2009-10-20 12:15:12.000000000 +0100
> +++ src/gdb/darwin-nat.c =A0 =A0 =A0 =A02009-10-20 12:16:03.000000000 +01=
00
> @@ -995,7 +995,7 @@ cancel_breakpoint (ptid_t ptid)
> =A0 CORE_ADDR pc;
>
> =A0 pc =3D regcache_read_pc (regcache) - gdbarch_decr_pc_after_break (gdb=
arch);
> - =A0if (breakpoint_inserted_here_p (pc))
> + =A0if (breakpoint_inserted_here_p (get_regcache_aspace (regcache), pc))
> =A0 =A0 {
> =A0 =A0 =A0 inferior_debug (4, "cancel_breakpoint for thread %x\n",
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0ptid_get_tid (ptid));
>
>
> --
> Pedro Alves
>