Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Michael Snyder <msnyder@vmware.com>,
	 	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Structure and simplify record log in record.c
Date: Thu, 15 Oct 2009 06:43:00 -0000	[thread overview]
Message-ID: <daef60380910142342q7c17311frcad08867d48e0b7b@mail.gmail.com> (raw)
In-Reply-To: <20091012231232.GH5272@adacore.com>

Thanks Michaael and Joel,

I think the other part of this patch is OK with me.

But you still has 2 patches "[RFA] Fix off-by-one error in record.c
(record_list_release_first)" and "[RFA] Expand "info record" will
change the code of record list.
So maybe this patch need some update according to these patches.

Thanks,
Hui

On Tue, Oct 13, 2009 at 07:12, Joel Brobecker <brobecker@adacore.com> wrote:
>> +/*
>> + * Alloc and free functions for record_reg, record_mem, and record_end
>> + * entries.
>> + */
>
> Can you reformat this to be:
>
> /* Alloc and free functions for record_reg, record_mem, and record_end
>   entries.  */
>
> ?
>
> This is really nit-picking, but I decided to comment on it because
> I'd rather not see two different styles being used in GDB...
>
>> +/* Alloc a record_mem record entry. */
>
> I alos just noticed a missing space here.
>
> --
> Joel
>


  reply	other threads:[~2009-10-15  6:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-12 17:36 Michael Snyder
2009-10-12 23:12 ` Joel Brobecker
2009-10-15  6:43   ` Hui Zhu [this message]
2009-10-15 17:16     ` Michael Snyder
2009-10-16  2:52       ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daef60380910142342q7c17311frcad08867d48e0b7b@mail.gmail.com \
    --to=teawater@gmail.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox