From: Joel Brobecker <brobecker@adacore.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Hui Zhu <teawater@gmail.com>
Subject: Re: [RFA] Structure and simplify record log in record.c
Date: Mon, 12 Oct 2009 23:12:00 -0000 [thread overview]
Message-ID: <20091012231232.GH5272@adacore.com> (raw)
In-Reply-To: <4AD367DC.9020901@vmware.com>
> +/*
> + * Alloc and free functions for record_reg, record_mem, and record_end
> + * entries.
> + */
Can you reformat this to be:
/* Alloc and free functions for record_reg, record_mem, and record_end
entries. */
?
This is really nit-picking, but I decided to comment on it because
I'd rather not see two different styles being used in GDB...
> +/* Alloc a record_mem record entry. */
I alos just noticed a missing space here.
--
Joel
next prev parent reply other threads:[~2009-10-12 23:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 17:36 Michael Snyder
2009-10-12 23:12 ` Joel Brobecker [this message]
2009-10-15 6:43 ` Hui Zhu
2009-10-15 17:16 ` Michael Snyder
2009-10-16 2:52 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012231232.GH5272@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox