From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4471 invoked by alias); 12 Oct 2009 23:12:45 -0000 Received: (qmail 4463 invoked by uid 22791); 12 Oct 2009 23:12:45 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Oct 2009 23:12:41 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 260CE2BAC25; Mon, 12 Oct 2009 19:12:40 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ubD2VN6tZrTk; Mon, 12 Oct 2009 19:12:40 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CD5F12BABE4; Mon, 12 Oct 2009 19:12:39 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 9B412F58A0; Mon, 12 Oct 2009 16:12:32 -0700 (PDT) Date: Mon, 12 Oct 2009 23:12:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: "gdb-patches@sourceware.org" , Hui Zhu Subject: Re: [RFA] Structure and simplify record log in record.c Message-ID: <20091012231232.GH5272@adacore.com> References: <4AD367DC.9020901@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AD367DC.9020901@vmware.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00253.txt.bz2 > +/* > + * Alloc and free functions for record_reg, record_mem, and record_end > + * entries. > + */ Can you reformat this to be: /* Alloc and free functions for record_reg, record_mem, and record_end entries. */ ? This is really nit-picking, but I decided to comment on it because I'd rather not see two different styles being used in GDB... > +/* Alloc a record_mem record entry. */ I alos just noticed a missing space here. -- Joel