From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10243 invoked by alias); 15 Oct 2009 06:43:16 -0000 Received: (qmail 10232 invoked by uid 22791); 15 Oct 2009 06:43:15 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-pz0-f192.google.com (HELO mail-pz0-f192.google.com) (209.85.222.192) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Oct 2009 06:43:10 +0000 Received: by pzk30 with SMTP id 30so554515pzk.24 for ; Wed, 14 Oct 2009 23:43:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.143.24.41 with SMTP id b41mr854183wfj.238.1255588989114; Wed, 14 Oct 2009 23:43:09 -0700 (PDT) In-Reply-To: <20091012231232.GH5272@adacore.com> References: <4AD367DC.9020901@vmware.com> <20091012231232.GH5272@adacore.com> From: Hui Zhu Date: Thu, 15 Oct 2009 06:43:00 -0000 Message-ID: Subject: Re: [RFA] Structure and simplify record log in record.c To: Joel Brobecker Cc: Michael Snyder , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00331.txt.bz2 Thanks Michaael and Joel, I think the other part of this patch is OK with me. But you still has 2 patches "[RFA] Fix off-by-one error in record.c (record_list_release_first)" and "[RFA] Expand "info record" will change the code of record list. So maybe this patch need some update according to these patches. Thanks, Hui On Tue, Oct 13, 2009 at 07:12, Joel Brobecker wrote: >> +/* >> + * Alloc and free functions for record_reg, record_mem, and record_end >> + * entries. >> + */ > > Can you reformat this to be: > > /* Alloc and free functions for record_reg, record_mem, and record_end > =A0 entries. =A0*/ > > ? > > This is really nit-picking, but I decided to comment on it because > I'd rather not see two different styles being used in GDB... > >> +/* Alloc a record_mem record entry. */ > > I alos just noticed a missing space here. > > -- > Joel >