From: Hui Zhu <teawater@gmail.com>
To: Aleksandar Ristovski <aristovski@qnx.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch] -Wall patches
Date: Sat, 08 Aug 2009 07:59:00 -0000 [thread overview]
Message-ID: <daef60380908071855x7d34da2dv1c17e1e3cc22c163@mail.gmail.com> (raw)
In-Reply-To: <h5fdom$ibb$1@ger.gmane.org>
2009/8/7 Aleksandar Ristovski <aristovski@qnx.com>:
> Hello,
>
>
> I have internally made changes necessary to get clean compile with -Wall
> compiler option. I tried to break down the patch to related files; I am
> intentionally not writing a changelog since most of the changes are
> mechanical and consist of removing unused variables, several unused
> functions, gdb_byte/char casting.
>
> I would not mind if respective maintainers looked at the patches for their
> files and committed the changes (otherwise it will be quite cumbersome and
> somewhat overwhelming for me to keep the patch applicable; not to mention
> change log and all).
>
>
> Thanks,
>
> --
> Aleksandar Ristovski
> QNX Software Systems
>
Thanks Aleksandar.
I will check in record.c patch under the obvious rule.
Hui
2009-08-08 Aleksandar Ristovski <aristovski@qnx.com>
Hui Zhu <teawater@gmail.com>
* record.c (record_store_registers): Remove unused variable.
Index: record.c
===================================================================
RCS file: /cvs/src/src/gdb/record.c,v
retrieving revision 1.10
diff -p -u -r1.10 record.c
--- record.c 4 Aug 2009 18:19:52 -0000 1.10
+++ record.c 8 Aug 2009 01:49:41 -0000
@@ -959,7 +959,6 @@ record_store_registers (struct target_op
if (RECORD_IS_REPLAY)
{
int n;
- struct cleanup *old_cleanups;
/* Let user choose if he wants to write register or not. */
if (regno < 0)
next prev parent reply other threads:[~2009-08-08 1:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 21:15 Aleksandar Ristovski
2009-08-07 3:05 ` Michael Snyder
2009-08-07 15:42 ` Aleksandar Ristovski
2009-08-07 17:46 ` Tom Tromey
2009-08-12 23:06 ` Michael Snyder
2009-08-08 7:59 ` Hui Zhu [this message]
2009-08-24 16:56 ` Pedro Alves
2009-08-25 17:20 ` Aleksandar Ristovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daef60380908071855x7d34da2dv1c17e1e3cc22c163@mail.gmail.com \
--to=teawater@gmail.com \
--cc=aristovski@qnx.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox