From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Aleksandar Ristovski <aristovski@qnx.com>
Subject: Re: [patch] -Wall patches
Date: Mon, 24 Aug 2009 16:56:00 -0000 [thread overview]
Message-ID: <200908241234.43838.pedro@codesourcery.com> (raw)
In-Reply-To: <h5fdom$ibb$1@ger.gmane.org>
I was quickly skimming through the patch, and I saw this:
On Thursday 06 August 2009 21:17:25, Aleksandar Ristovski wrote:
> --- src0/gdb/valops.c 2009-07-31 14:43:27.000000000 -0400
> +++ src1/gdb/valops.c 2009-08-06 09:04:20.000000000 -0400
> @@ -270,7 +270,6 @@ value_cast_structs (struct type *type, s
> struct value *
> value_cast_pointers (struct type *type, struct value *arg2)
> {
> - struct type *type1 = check_typedef (type);
> struct type *type2 = check_typedef (value_type (arg2));
> struct type *t1 = check_typedef (TYPE_TARGET_TYPE (type));
> struct type *t2 = check_typedef (TYPE_TARGET_TYPE (type2));
> @@ -866,6 +865,9 @@ value_assign (struct value *toval, struc
> value_reg = VALUE_REGNUM (toval);
>
> if (!frame)
> + frame = get_current_frame ();
> +
> + if (!frame)
> error (_("Value being assigned to is no longer active."));
>
Looks like it was accidentally included. It looks like the
workaround for "set reg=foo", when there's no valid frame id.
--
Pedro Alves
next prev parent reply other threads:[~2009-08-24 11:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 21:15 Aleksandar Ristovski
2009-08-07 3:05 ` Michael Snyder
2009-08-07 15:42 ` Aleksandar Ristovski
2009-08-07 17:46 ` Tom Tromey
2009-08-12 23:06 ` Michael Snyder
2009-08-08 7:59 ` Hui Zhu
2009-08-24 16:56 ` Pedro Alves [this message]
2009-08-25 17:20 ` Aleksandar Ristovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908241234.43838.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=aristovski@qnx.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox