From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-66188-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10795 invoked by alias); 24 Aug 2009 11:34:53 -0000
Received: (qmail 10787 invoked by uid 22791); 24 Aug 2009 11:34:52 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Aug 2009 11:34:44 +0000
Received: (qmail 30380 invoked from network); 24 Aug 2009 11:34:42 -0000
Received: from unknown (HELO orlando) (pedro@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 24 Aug 2009 11:34:42 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [patch] -Wall patches
Date: Mon, 24 Aug 2009 16:56:00 -0000
User-Agent: KMail/1.9.10
Cc: Aleksandar Ristovski <aristovski@qnx.com>
References: <h5fdom$ibb$1@ger.gmane.org>
In-Reply-To: <h5fdom$ibb$1@ger.gmane.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;   charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200908241234.43838.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-08/txt/msg00387.txt.bz2

I was quickly skimming through the patch, and I saw this:

On Thursday 06 August 2009 21:17:25, Aleksandar Ristovski wrote:
> --- src0/gdb/valops.c=A0=A0=A02009-07-31 14:43:27.000000000 -0400
> +++ src1/gdb/valops.c=A0=A0=A02009-08-06 09:04:20.000000000 -0400
> @@ -270,7 +270,6 @@ value_cast_structs (struct type *type, s
> =A0struct value *
> =A0value_cast_pointers (struct type *type, struct value *arg2)
> =A0{
> - =A0struct type *type1 =3D check_typedef (type);
> =A0 =A0struct type *type2 =3D check_typedef (value_type (arg2));
> =A0 =A0struct type *t1 =3D check_typedef (TYPE_TARGET_TYPE (type));
> =A0 =A0struct type *t2 =3D check_typedef (TYPE_TARGET_TYPE (type2));
> @@ -866,6 +865,9 @@ value_assign (struct value *toval, struc
> =A0=A0=A0=A0=A0=A0=A0=A0value_reg =3D VALUE_REGNUM (toval);
> =A0
> =A0=A0=A0=A0=A0=A0=A0=A0if (!frame)
> +=A0=A0=A0=A0=A0=A0=A0 =A0frame =3D get_current_frame ();
> +
> +=A0=A0=A0=A0=A0=A0=A0if (!frame)
> =A0=A0=A0=A0=A0=A0=A0=A0 =A0error (_("Value being assigned to is no longe=
r active."));
> =A0

Looks like it was accidentally included.  It looks like the
workaround for "set reg=3Dfoo", when there's no valid frame id.

--=20
Pedro Alves