From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1111 invoked by alias); 8 Aug 2009 01:55:46 -0000 Received: (qmail 1069 invoked by uid 22791); 8 Aug 2009 01:55:45 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-gx0-f208.google.com (HELO mail-gx0-f208.google.com) (209.85.217.208) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 08 Aug 2009 01:55:38 +0000 Received: by gxk4 with SMTP id 4so2380646gxk.2 for ; Fri, 07 Aug 2009 18:55:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.37.73 with SMTP id w9mr941499ibd.2.1249696536297; Fri, 07 Aug 2009 18:55:36 -0700 (PDT) In-Reply-To: References: From: Hui Zhu Date: Sat, 08 Aug 2009 07:59:00 -0000 Message-ID: Subject: Re: [patch] -Wall patches To: Aleksandar Ristovski Cc: gdb-patches@sources.redhat.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00123.txt.bz2 2009/8/7 Aleksandar Ristovski : > Hello, > > > I have internally made changes necessary to get clean compile with -Wall > compiler option. I tried to break down the patch to related files; I am > intentionally not writing a changelog since most of the changes are > mechanical and consist of removing unused variables, several unused > functions, gdb_byte/char casting. > > I would not mind if respective maintainers looked at the patches for their > files and committed the changes (otherwise it will be quite cumbersome and > somewhat overwhelming for me to keep the patch applicable; not to mention > change log and all). > > > Thanks, > > -- > Aleksandar Ristovski > QNX Software Systems > Thanks Aleksandar. I will check in record.c patch under the obvious rule. Hui 2009-08-08 Aleksandar Ristovski Hui Zhu * record.c (record_store_registers): Remove unused variable. Index: record.c =================================================================== RCS file: /cvs/src/src/gdb/record.c,v retrieving revision 1.10 diff -p -u -r1.10 record.c --- record.c 4 Aug 2009 18:19:52 -0000 1.10 +++ record.c 8 Aug 2009 01:49:41 -0000 @@ -959,7 +959,6 @@ record_store_registers (struct target_op if (RECORD_IS_REPLAY) { int n; - struct cleanup *old_cleanups; /* Let user choose if he wants to write register or not. */ if (regno < 0)