Re: [Prec/RFA] Remove macros for record size in i386-linux-tdep.c

[Hui Zhu <teawater@gmail.com>]

On Sun, May 24, 2009 at 01:27, Pedro Alves <pedro@codesourcery.com> wrote:
> On Saturday 23 May 2009 18:13:34, Hui Zhu wrote:
>
>> >> > OK.  I make a new patch remove it.
>> >> > Please help me review it.
>> >> >
>> >> > Thanks,
>> >> > Hui
>> >> >
>> >> > 2009-05-23  Hui Zhu  <teawater@gmail.com>
>> >> >
>> >> >        * i386-linux-tdep.c (I386_LINUX_RECORD_SIZE_*,
>> >> >        I386_LINUX_RECORD_IOCTL_*,
>> >> >        I386_LINUX_RECORD_FCNTL_*) Removed.
>> >> >        (i386_linux_init_abi): Change size of record from macros to
>> >> >        numbers.
>> >> >
>> >> >        * i386-linux-tdep.c (i386_linux_init_abi): Remove size_char.
>> >> >        * linux-record.c (record_linux_system_call): Ditto.
>> >> >        * linux-record.h (linux_record_tdep): Ditto.
>> >
>> > This is OK, although the changelog wants to record different unrelated
>> > changes: either commit this in two parts, or merge the (i386_linux_init_abi)
>> > entries.
>> >
>
>> What about the last patch? It remove char_size.
>
> Already OKed above.

Thanks.  Checked in and I divided changelog to 2 parts:
2009-05-24  Hui Zhu  <teawater@gmail.com>

	* i386-linux-tdep.c (I386_LINUX_RECORD_SIZE_*,
	I386_LINUX_RECORD_IOCTL_*,
	I386_LINUX_RECORD_FCNTL_*) Removed.
	(i386_linux_init_abi): Change size of record from macros to
	numbers.

2009-05-24  Hui Zhu  <teawater@gmail.com>

	* i386-linux-tdep.c (i386_linux_init_abi): Remove size_char.
	* linux-record.c (record_linux_system_call): Ditto.
	* linux-record.h (linux_record_tdep): Ditto.


Hui