From: Pedro Alves <pedro@codesourcery.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [Prec/RFA] Remove macros for record size in i386-linux-tdep.c
Date: Sat, 23 May 2009 17:27:00 -0000 [thread overview]
Message-ID: <200905231827.41604.pedro@codesourcery.com> (raw)
In-Reply-To: <daef60380905231013j2393c13ct4e1eb70e248a5119@mail.gmail.com>
On Saturday 23 May 2009 18:13:34, Hui Zhu wrote:
> >> > OK. I make a new patch remove it.
> >> > Please help me review it.
> >> >
> >> > Thanks,
> >> > Hui
> >> >
> >> > 2009-05-23 Hui Zhu <teawater@gmail.com>
> >> >
> >> > * i386-linux-tdep.c (I386_LINUX_RECORD_SIZE_*,
> >> > I386_LINUX_RECORD_IOCTL_*,
> >> > I386_LINUX_RECORD_FCNTL_*) Removed.
> >> > (i386_linux_init_abi): Change size of record from macros to
> >> > numbers.
> >> >
> >> > * i386-linux-tdep.c (i386_linux_init_abi): Remove size_char.
> >> > * linux-record.c (record_linux_system_call): Ditto.
> >> > * linux-record.h (linux_record_tdep): Ditto.
> >
> > This is OK, although the changelog wants to record different unrelated
> > changes: either commit this in two parts, or merge the (i386_linux_init_abi)
> > entries.
> >
> What about the last patch? It remove char_size.
Already OKed above.
--
Pedro Alves
next prev parent reply other threads:[~2009-05-23 17:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-23 4:00 Hui Zhu
2009-05-23 11:12 ` Pedro Alves
2009-05-23 11:59 ` Hui Zhu
2009-05-23 12:13 ` Hui Zhu
2009-05-23 13:47 ` Pedro Alves
2009-05-23 17:13 ` Hui Zhu
2009-05-23 17:27 ` Pedro Alves [this message]
2009-05-24 4:48 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905231827.41604.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox