From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-63957-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14407 invoked by alias); 23 May 2009 17:27:49 -0000
Received: (qmail 14398 invoked by uid 22791); 23 May 2009 17:27:49 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 23 May 2009 17:27:41 +0000
Received: (qmail 32585 invoked from network); 23 May 2009 17:27:39 -0000
Received: from unknown (HELO orlando.local) (pedro@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 23 May 2009 17:27:39 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: Hui Zhu <teawater@gmail.com>
Subject: Re: [Prec/RFA] Remove macros for record size in i386-linux-tdep.c
Date: Sat, 23 May 2009 17:27:00 -0000
User-Agent: KMail/1.9.10
Cc: gdb-patches@sourceware.org
References: <daef60380905222100i7f686d23x198658d328a158d8@mail.gmail.com> <200905231447.45945.pedro@codesourcery.com> <daef60380905231013j2393c13ct4e1eb70e248a5119@mail.gmail.com>
In-Reply-To: <daef60380905231013j2393c13ct4e1eb70e248a5119@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;   charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200905231827.41604.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-05/txt/msg00520.txt.bz2

On Saturday 23 May 2009 18:13:34, Hui Zhu wrote:

> >> > OK. =A0I make a new patch remove it.
> >> > Please help me review it.
> >> >
> >> > Thanks,
> >> > Hui
> >> >
> >> > 2009-05-23 =A0Hui Zhu =A0<teawater@gmail.com>
> >> >
> >> > =A0 =A0 =A0 =A0* i386-linux-tdep.c (I386_LINUX_RECORD_SIZE_*,
> >> > =A0 =A0 =A0 =A0I386_LINUX_RECORD_IOCTL_*,
> >> > =A0 =A0 =A0 =A0I386_LINUX_RECORD_FCNTL_*) Removed.
> >> > =A0 =A0 =A0 =A0(i386_linux_init_abi): Change size of record from mac=
ros to
> >> > =A0 =A0 =A0 =A0numbers.
> >> >
> >> > =A0 =A0 =A0 =A0* i386-linux-tdep.c (i386_linux_init_abi): Remove siz=
e_char.
> >> > =A0 =A0 =A0 =A0* linux-record.c (record_linux_system_call): Ditto.
> >> > =A0 =A0 =A0 =A0* linux-record.h (linux_record_tdep): Ditto.
> >
> > This is OK, although the changelog wants to record different unrelated
> > changes: either commit this in two parts, or merge the (i386_linux_init=
_abi)
> > entries.
> >

> What about the last patch? It remove char_size.

Already OKed above.

--=20
Pedro Alves