From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27533 invoked by alias); 24 May 2009 04:48:17 -0000 Received: (qmail 27520 invoked by uid 22791); 24 May 2009 04:48:14 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from rv-out-0708.google.com (HELO rv-out-0708.google.com) (209.85.198.247) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 24 May 2009 04:48:10 +0000 Received: by rv-out-0708.google.com with SMTP id k29so841182rvb.48 for ; Sat, 23 May 2009 21:48:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.110.109.19 with SMTP id h19mr159095tic.44.1243140487028; Sat, 23 May 2009 21:48:07 -0700 (PDT) In-Reply-To: <200905231827.41604.pedro@codesourcery.com> References: <200905231447.45945.pedro@codesourcery.com> <200905231827.41604.pedro@codesourcery.com> Date: Sun, 24 May 2009 04:48:00 -0000 Message-ID: Subject: Re: [Prec/RFA] Remove macros for record size in i386-linux-tdep.c From: Hui Zhu To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00528.txt.bz2 On Sun, May 24, 2009 at 01:27, Pedro Alves wrote: > On Saturday 23 May 2009 18:13:34, Hui Zhu wrote: > >> >> > OK. =A0I make a new patch remove it. >> >> > Please help me review it. >> >> > >> >> > Thanks, >> >> > Hui >> >> > >> >> > 2009-05-23 =A0Hui Zhu =A0 >> >> > >> >> > =A0 =A0 =A0 =A0* i386-linux-tdep.c (I386_LINUX_RECORD_SIZE_*, >> >> > =A0 =A0 =A0 =A0I386_LINUX_RECORD_IOCTL_*, >> >> > =A0 =A0 =A0 =A0I386_LINUX_RECORD_FCNTL_*) Removed. >> >> > =A0 =A0 =A0 =A0(i386_linux_init_abi): Change size of record from ma= cros to >> >> > =A0 =A0 =A0 =A0numbers. >> >> > >> >> > =A0 =A0 =A0 =A0* i386-linux-tdep.c (i386_linux_init_abi): Remove si= ze_char. >> >> > =A0 =A0 =A0 =A0* linux-record.c (record_linux_system_call): Ditto. >> >> > =A0 =A0 =A0 =A0* linux-record.h (linux_record_tdep): Ditto. >> > >> > This is OK, although the changelog wants to record different unrelated >> > changes: either commit this in two parts, or merge the (i386_linux_ini= t_abi) >> > entries. >> > > >> What about the last patch? It remove char_size. > > Already OKed above. Thanks. Checked in and I divided changelog to 2 parts: 2009-05-24 Hui Zhu * i386-linux-tdep.c (I386_LINUX_RECORD_SIZE_*, I386_LINUX_RECORD_IOCTL_*, I386_LINUX_RECORD_FCNTL_*) Removed. (i386_linux_init_abi): Change size of record from macros to numbers. 2009-05-24 Hui Zhu * i386-linux-tdep.c (i386_linux_init_abi): Remove size_char. * linux-record.c (record_linux_system_call): Ditto. * linux-record.h (linux_record_tdep): Ditto. Hui