Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [RFA] print error message if (auto) disassembly failed
Date: Fri, 17 Apr 2009 07:33:00 -0000	[thread overview]
Message-ID: <daef60380904170033k3139576fjc3b859f4d22544c8@mail.gmail.com> (raw)
In-Reply-To: <20090416235735.GO7585@adacore.com>

I try it in x86-linux with simple inferior and core file.
This patch works very well.

Thanks,
Hui

On Fri, Apr 17, 2009 at 07:57, Joel Brobecker <brobecker@adacore.com> wrote:
>> OK, but your suggested message text is too long, I think.  Something
>> shorter, like "(address unreadable)" is better, IMO.
>
> Frankly, I think this is overkill - even with the 64bit addresses
> the line was still less than 70 characters long. But I'm not going
> to argue. Here you go:
>
>    (gdb) core core
>    warning: core file may not match specified executable file.
>    Core was generated by `./crash'.
>    Program terminated with signal 6, Aborted.
>    #0  0x00007fe6fe543307 in ?? ()
>    0x00007fe6fe543307:     (cannot read memory)
>
> 2009-04-17  Joel Brobecker  <brobecker@adacore.com>
>
>        * stack.c (do_gdb_disassembly): Print an error message if an error
>        was thrown while trying to perform the disassembly.
>
> I'm currently testing this patch on x86_64-linux, but I don't really
> expect any problem.
>
> --
> Joel
>


  reply	other threads:[~2009-04-17  7:33 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-16 17:39 Joel Brobecker
2009-04-16 17:52 ` Eli Zaretskii
2009-04-16 18:02   ` Joel Brobecker
2009-04-16 18:16     ` Eli Zaretskii
2009-04-16 19:07       ` Joel Brobecker
2009-04-16 21:37         ` Eli Zaretskii
2009-04-16 21:54           ` Joel Brobecker
2009-04-16 22:09             ` Pedro Alves
2009-04-17  9:10             ` Eli Zaretskii
2009-04-16 23:57           ` Joel Brobecker
2009-04-17  7:33             ` Hui Zhu [this message]
2009-04-17  9:22             ` Eli Zaretskii
2009-04-17 15:50               ` Joel Brobecker
2009-04-17 17:34             ` Daniel Jacobowitz
2009-04-17 22:16               ` Joel Brobecker
2009-04-18  6:48                 ` Eli Zaretskii
2009-04-16 22:23 ` Tom Tromey
2009-04-16 23:59   ` Joel Brobecker
2009-04-17  5:33     ` Hui Zhu
2009-04-17 15:57       ` Joel Brobecker
2009-04-17 16:16         ` Tom Tromey
2009-04-17 16:59         ` Hui Zhu
2009-04-17  9:23     ` Eli Zaretskii
2009-04-17 10:05       ` Eli Zaretskii
2009-04-23 18:49 ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daef60380904170033k3139576fjc3b859f4d22544c8@mail.gmail.com \
    --to=teawater@gmail.com \
    --cc=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox