From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10913 invoked by alias); 17 Apr 2009 07:33:23 -0000 Received: (qmail 10904 invoked by uid 22791); 17 Apr 2009 07:33:22 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.191) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 17 Apr 2009 07:33:16 +0000 Received: by ti-out-0910.google.com with SMTP id a1so488336tib.12 for ; Fri, 17 Apr 2009 00:33:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.110.69.5 with SMTP id r5mr1801060tia.22.1239953591326; Fri, 17 Apr 2009 00:33:11 -0700 (PDT) In-Reply-To: <20090416235735.GO7585@adacore.com> References: <20090416173918.GP7557@adacore.com> <834owolc51.fsf@gnu.org> <20090416180146.GH7585@adacore.com> <831vrslb0f.fsf@gnu.org> <20090416190654.GJ7585@adacore.com> <83vdp4jn6j.fsf@gnu.org> <20090416235735.GO7585@adacore.com> Date: Fri, 17 Apr 2009 07:33:00 -0000 Message-ID: Subject: Re: [RFA] print error message if (auto) disassembly failed From: Hui Zhu To: Joel Brobecker Cc: Eli Zaretskii , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00411.txt.bz2 I try it in x86-linux with simple inferior and core file. This patch works very well. Thanks, Hui On Fri, Apr 17, 2009 at 07:57, Joel Brobecker wrote: >> OK, but your suggested message text is too long, I think. =A0Something >> shorter, like "(address unreadable)" is better, IMO. > > Frankly, I think this is overkill - even with the 64bit addresses > the line was still less than 70 characters long. But I'm not going > to argue. Here you go: > > =A0 =A0(gdb) core core > =A0 =A0warning: core file may not match specified executable file. > =A0 =A0Core was generated by `./crash'. > =A0 =A0Program terminated with signal 6, Aborted. > =A0 =A0#0 =A00x00007fe6fe543307 in ?? () > =A0 =A00x00007fe6fe543307: =A0 =A0 (cannot read memory) > > 2009-04-17 =A0Joel Brobecker =A0 > > =A0 =A0 =A0 =A0* stack.c (do_gdb_disassembly): Print an error message if = an error > =A0 =A0 =A0 =A0was thrown while trying to perform the disassembly. > > I'm currently testing this patch on x86_64-linux, but I don't really > expect any problem. > > -- > Joel >