From: Hui Zhu <teawater@gmail.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org,
Mark Kettenis <mark.kettenis@xs4all.nl>,
marc.khouzam@ericsson.com, msnyder@vmware.com,
bauerman@br.ibm.com, eliz@gnu.org, paawan1982@yahoo.com
Subject: Re: [RFA] Submit process record and replay fourth time, 7/8
Date: Sun, 22 Mar 2009 16:43:00 -0000 [thread overview]
Message-ID: <daef60380903220859h28af500bl14d8be4ce43e8f5c@mail.gmail.com> (raw)
In-Reply-To: <200903221530.52997.pedro@codesourcery.com>
Hi Pedro,
On Sun, Mar 22, 2009 at 23:30, Pedro Alves <pedro@codesourcery.com> wrote:
>
> The way this is written looks like there's a bunch
> of unneeded duplication.
>
> +#define I386_LINUX_RECORD_SIZE__old_kernel_stat 32
>
> + /* Initialize the i386_linux_record_tdep. */
> + i386_linux_record_tdep.size__old_kernel_stat =
> + I386_LINUX_RECORD_SIZE__old_kernel_stat;
>
> Are the I386_LINUX_RECORD_SIZE__XXXXX defines used for
> anything else other than initializing the corresponding
> i386_linux_record_tdep.size_XXXXX field? If not, why not
> drop the defines and just write
>
> i386_linux_record_tdep.size__old_kernel_stat = 32;
Yes, you are right. I will do it.
>
> ?
>
> Personally, I think that stamping everything with "record" in
> its name is a mistake. This is about the linux syscall abi,
> could be reused for something else...
>
About this part, we have a discussion in
http://sourceware.org/ml/gdb-patches/2008-11/msg00171.html
We will make it better later.
Thanks,
Hui
next prev parent reply other threads:[~2009-03-22 16:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-21 16:05 Hui Zhu
2009-03-21 16:23 ` Mark Kettenis
2009-03-22 14:55 ` Hui Zhu
2009-03-22 15:37 ` Pedro Alves
2009-03-22 16:43 ` Hui Zhu [this message]
2009-03-22 16:47 ` Hui Zhu
2009-03-22 17:01 ` Pedro Alves
2009-03-22 17:10 ` Hui Zhu
2009-03-22 17:32 ` Pedro Alves
2009-03-22 23:52 ` Hui Zhu
2009-03-22 21:53 ` Mark Kettenis
2009-03-23 2:12 ` Hui Zhu
2009-04-15 17:10 ` Hui Zhu
2009-04-28 10:05 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daef60380903220859h28af500bl14d8be4ce43e8f5c@mail.gmail.com \
--to=teawater@gmail.com \
--cc=bauerman@br.ibm.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=marc.khouzam@ericsson.com \
--cc=mark.kettenis@xs4all.nl \
--cc=msnyder@vmware.com \
--cc=paawan1982@yahoo.com \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox