From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: pedro@codesourcery.com
Cc: gdb-patches@sourceware.org, teawater@gmail.com,
mark.kettenis@xs4all.nl, marc.khouzam@ericsson.com,
msnyder@vmware.com, bauerman@br.ibm.com, eliz@gnu.org,
paawan1982@yahoo.com
Subject: Re: [RFA] Submit process record and replay fourth time, 7/8
Date: Sun, 22 Mar 2009 21:53:00 -0000 [thread overview]
Message-ID: <200903222122.n2MLMFr4011417@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <200903221647.10605.pedro@codesourcery.com> (message from Pedro Alves on Sun, 22 Mar 2009 16:47:09 +0000)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
> From: Pedro Alves <pedro@codesourcery.com>
> Date: Sun, 22 Mar 2009 16:47:09 +0000
>
> On Sunday 22 March 2009 16:43:36, Hui Zhu wrote:
> > About this part, I think it again. I think keep it to macro is
> > better. Because all of values can't be change. Set them to variable
> > just to make record linux code more friendly to other arch. So I
> > think make it to macro is more clear.
>
> I don't think it's clearer at all. I think it's just clutter.
For what it is worth, I agree with Pedro here. If there is a bunch of
constants like this that are only used once, adding #defines for them
is a bit counterproductive.
Oh, and in one of the comments there is a space missing in Linux2.4.
next prev parent reply other threads:[~2009-03-22 21:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-21 16:05 Hui Zhu
2009-03-21 16:23 ` Mark Kettenis
2009-03-22 14:55 ` Hui Zhu
2009-03-22 15:37 ` Pedro Alves
2009-03-22 16:43 ` Hui Zhu
2009-03-22 16:47 ` Hui Zhu
2009-03-22 17:01 ` Pedro Alves
2009-03-22 17:10 ` Hui Zhu
2009-03-22 17:32 ` Pedro Alves
2009-03-22 23:52 ` Hui Zhu
2009-03-22 21:53 ` Mark Kettenis [this message]
2009-03-23 2:12 ` Hui Zhu
2009-04-15 17:10 ` Hui Zhu
2009-04-28 10:05 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903222122.n2MLMFr4011417@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=bauerman@br.ibm.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=marc.khouzam@ericsson.com \
--cc=msnyder@vmware.com \
--cc=paawan1982@yahoo.com \
--cc=pedro@codesourcery.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox