From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28744 invoked by alias); 22 Mar 2009 21:24:04 -0000 Received: (qmail 28736 invoked by uid 22791); 22 Mar 2009 21:24:03 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 22 Mar 2009 21:23:52 +0000 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id n2MLMJpT031431; Sun, 22 Mar 2009 22:22:19 +0100 (CET) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id n2MLMFr4011417; Sun, 22 Mar 2009 22:22:15 +0100 (CET) Date: Sun, 22 Mar 2009 21:53:00 -0000 Message-Id: <200903222122.n2MLMFr4011417@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: pedro@codesourcery.com CC: gdb-patches@sourceware.org, teawater@gmail.com, mark.kettenis@xs4all.nl, marc.khouzam@ericsson.com, msnyder@vmware.com, bauerman@br.ibm.com, eliz@gnu.org, paawan1982@yahoo.com In-reply-to: <200903221647.10605.pedro@codesourcery.com> (message from Pedro Alves on Sun, 22 Mar 2009 16:47:09 +0000) Subject: Re: [RFA] Submit process record and replay fourth time, 7/8 References: <200903221647.10605.pedro@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00463.txt.bz2 > From: Pedro Alves > Date: Sun, 22 Mar 2009 16:47:09 +0000 > > On Sunday 22 March 2009 16:43:36, Hui Zhu wrote: > > About this part, I think it again.  I think keep it to macro is > > better.  Because all of values can't be change.  Set them to variable > > just to make record linux code more friendly to other arch.  So I > > think make it to macro is more clear. > > I don't think it's clearer at all. I think it's just clutter. For what it is worth, I agree with Pedro here. If there is a bunch of constants like this that are only used once, adding #defines for them is a bit counterproductive. Oh, and in one of the comments there is a space missing in Linux2.4.