Re: [RFA] Submit process record and replay fourth time, 7/8

Pedro Alves
2009-03-22T15:31:03Z

The way this is written looks like there's a bunch
of unneeded duplication.

+#define I386_LINUX_RECORD_SIZE__old_kernel_stat 32

+ /* Initialize the i386_linux_record_tdep. */
+ i386_linux_record_tdep.size__old_kernel_stat =
+ I386_LINUX_RECORD_SIZE__old_kernel_stat;

Are the I386_LINUX_RECORD_SIZE__XXXXX defines used for
anything else other than initializing the corresponding
i386_linux_record_tdep.size_XXXXX field? If not, why not
drop the defines and just write

i386_linux_record_tdep.size__old_kernel_stat = 32;

?

Personally, I think that stamping everything with "record" in
its name is a mistake. This is about the linux syscall abi,
could be reused for something else...

--
Pedro Alves