Re: [RFA] Submit process record and replay fourth time, 7/8

Hui Zhu
2009-03-22T16:43:46Z

Hi Pedro,

On Sun, Mar 22, 2009 at 23:59, Hui Zhu <teawater@gmail.com> wrote:
> Hi Pedro,
>
> On Sun, Mar 22, 2009 at 23:30, Pedro Alves <pedro@codesourcery.com> wrote:
>>
>> The way this is written looks like there's a bunch
>> of unneeded duplication.
>>
>>  +#define I386_LINUX_RECORD_SIZE__old_kernel_stat        32
>>
>>  +  /* Initialize the i386_linux_record_tdep.  */
>>  +  i386_linux_record_tdep.size__old_kernel_stat =
>>  +    I386_LINUX_RECORD_SIZE__old_kernel_stat;
>>
>> Are the I386_LINUX_RECORD_SIZE__XXXXX defines used for
>> anything else other than initializing the corresponding
>> i386_linux_record_tdep.size_XXXXX field?  If not, why not
>> drop the defines and just write
>>
>>  i386_linux_record_tdep.size__old_kernel_stat = 32;
>
> Yes, you are right.  I will do it.

About this part, I think it again. I think keep it to macro is
better. Because all of values can't be change. Set them to variable
just to make record linux code more friendly to other arch. So I
think make it to macro is more clear.

Thanks,
Hui