Re: [RFA] Submit process record and replay fourth time, 7/8

Mark Kettenis
2009-03-22T21:24:04Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Sun, 22 Mar 2009 16:47:09 +0000
>
> On Sunday 22 March 2009 16:43:36, Hui Zhu wrote:
> > About this part, I think it again.  I think keep it to macro is
> > better.  Because all of values can't be change.  Set them to variable
> > just to make record linux code more friendly to other arch.  So I
> > think make it to macro is more clear.
>
> I don't think it's clearer at all. I think it's just clutter.

For what it is worth, I agree with Pedro here. If there is a bunch of
constants like this that are only used once, adding #defines for them
is a bit counterproductive.

Oh, and in one of the comments there is a space missing in Linux2.4.