[RFA] Patch to fix "reverse-step" command error

[teawater <teawater@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

Hi Michael,

This patch is for bug in
http://sourceware.org/ml/gdb-patches/2009-02/msg00246.html.

The reason of bug is when inferior reverse exection into dynsym
resolve code, gdb doesn't insert breakpoint in right address.
It just happen in some distributions for example SLED.

This patch make gdb insert breakpoint in right address or step in that case.

2008-03-02  Hui Zhu  <teawater@gmail.com>

       * infrun.c (handle_inferior_event): Make inferior insert
       breakpoint at right address or step in reverse and it stepped
       into dynsym resolve code.

Thanks,
Hui

[-- Attachment #2: fix-reverse-dynsym-error.txt --]
[-- Type: text/plain, Size: 1409 bytes --]

---
 infrun.c |   31 ++++++++++++++++++++++++++-----
 1 file changed, 26 insertions(+), 5 deletions(-)

--- a/infrun.c
+++ b/infrun.c
@@ -3412,13 +3412,34 @@ infrun: BPSTAT_WHAT_SET_LONGJMP_RESUME (
 
       if (pc_after_resolver)
 	{
-	  /* Set up a step-resume breakpoint at the address
-	     indicated by SKIP_SOLIB_RESOLVER.  */
 	  struct symtab_and_line sr_sal;
-	  init_sal (&sr_sal);
-	  sr_sal.pc = pc_after_resolver;
+	  if (execution_direction == EXEC_REVERSE)
+	    {
+	      if (ecs->stop_func_start != stop_pc)
+		{
+		  /* Normal (staticly linked) function call return.  */
+		  init_sal (&sr_sal);
+		  sr_sal.pc = ecs->stop_func_start;
+		  insert_step_resume_breakpoint_at_sal (sr_sal, null_frame_id);
+		}
+	      else
+		{
+		  /* We are stepping over a function call in reverse, and
+	             stop at the start address of the function.  Go back to
+	             single-stepping, which should take us back to the
+	             function call.  */
+		  ecs->event_thread->stepping_over_breakpoint = 1;
+		}
+	    }
+	  else
+	    {
+	      /* Set up a step-resume breakpoint at the address
+	         indicated by SKIP_SOLIB_RESOLVER.  */
+	      init_sal (&sr_sal);
+	      sr_sal.pc = pc_after_resolver;
 
-	  insert_step_resume_breakpoint_at_sal (sr_sal, null_frame_id);
+	      insert_step_resume_breakpoint_at_sal (sr_sal, null_frame_id);
+	    }
 	}
 
       keep_going (ecs);