From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18275 invoked by alias); 2 Mar 2009 06:10:17 -0000 Received: (qmail 18265 invoked by uid 22791); 2 Mar 2009 06:10:16 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.185) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Mar 2009 06:10:11 +0000 Received: by ti-out-0910.google.com with SMTP id y8so2619571tia.12 for ; Sun, 01 Mar 2009 22:10:08 -0800 (PST) MIME-Version: 1.0 Received: by 10.110.57.5 with SMTP id f5mr8145613tia.49.1235974207954; Sun, 01 Mar 2009 22:10:07 -0800 (PST) Date: Mon, 02 Mar 2009 06:10:00 -0000 Message-ID: Subject: [RFA] Patch to fix "reverse-step" command error From: teawater To: Michael Snyder Cc: "gdb-patches@sourceware.org" , Marc Khouzam Content-Type: multipart/mixed; boundary=001485f01d609de11004641caba5 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00005.txt.bz2 --001485f01d609de11004641caba5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 581 Hi Michael, This patch is for bug in http://sourceware.org/ml/gdb-patches/2009-02/msg00246.html. The reason of bug is when inferior reverse exection into dynsym resolve code, gdb doesn't insert breakpoint in right address. It just happen in some distributions for example SLED. This patch make gdb insert breakpoint in right address or step in that case. 2008-03-02 Hui Zhu * infrun.c (handle_inferior_event): Make inferior insert breakpoint at right address or step in reverse and it stepped into dynsym resolve code. Thanks, Hui --001485f01d609de11004641caba5 Content-Type: text/plain; charset=US-ASCII; name="fix-reverse-dynsym-error.txt" Content-Disposition: attachment; filename="fix-reverse-dynsym-error.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_frsrhzlb0 Content-length: 1912 LS0tCiBpbmZydW4uYyB8ICAgMzEgKysrKysrKysrKysrKysrKysrKysrKysr KystLS0tLQogMSBmaWxlIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDUg ZGVsZXRpb25zKC0pCgotLS0gYS9pbmZydW4uYworKysgYi9pbmZydW4uYwpA QCAtMzQxMiwxMyArMzQxMiwzNCBAQCBpbmZydW46IEJQU1RBVF9XSEFUX1NF VF9MT05HSk1QX1JFU1VNRSAoCiAKICAgICAgIGlmIChwY19hZnRlcl9yZXNv bHZlcikKIAl7Ci0JICAvKiBTZXQgdXAgYSBzdGVwLXJlc3VtZSBicmVha3Bv aW50IGF0IHRoZSBhZGRyZXNzCi0JICAgICBpbmRpY2F0ZWQgYnkgU0tJUF9T T0xJQl9SRVNPTFZFUi4gICovCiAJICBzdHJ1Y3Qgc3ltdGFiX2FuZF9saW5l IHNyX3NhbDsKLQkgIGluaXRfc2FsICgmc3Jfc2FsKTsKLQkgIHNyX3NhbC5w YyA9IHBjX2FmdGVyX3Jlc29sdmVyOworCSAgaWYgKGV4ZWN1dGlvbl9kaXJl Y3Rpb24gPT0gRVhFQ19SRVZFUlNFKQorCSAgICB7CisJICAgICAgaWYgKGVj cy0+c3RvcF9mdW5jX3N0YXJ0ICE9IHN0b3BfcGMpCisJCXsKKwkJICAvKiBO b3JtYWwgKHN0YXRpY2x5IGxpbmtlZCkgZnVuY3Rpb24gY2FsbCByZXR1cm4u ICAqLworCQkgIGluaXRfc2FsICgmc3Jfc2FsKTsKKwkJICBzcl9zYWwucGMg PSBlY3MtPnN0b3BfZnVuY19zdGFydDsKKwkJICBpbnNlcnRfc3RlcF9yZXN1 bWVfYnJlYWtwb2ludF9hdF9zYWwgKHNyX3NhbCwgbnVsbF9mcmFtZV9pZCk7 CisJCX0KKwkgICAgICBlbHNlCisJCXsKKwkJICAvKiBXZSBhcmUgc3RlcHBp bmcgb3ZlciBhIGZ1bmN0aW9uIGNhbGwgaW4gcmV2ZXJzZSwgYW5kCisJICAg ICAgICAgICAgIHN0b3AgYXQgdGhlIHN0YXJ0IGFkZHJlc3Mgb2YgdGhlIGZ1 bmN0aW9uLiAgR28gYmFjayB0bworCSAgICAgICAgICAgICBzaW5nbGUtc3Rl cHBpbmcsIHdoaWNoIHNob3VsZCB0YWtlIHVzIGJhY2sgdG8gdGhlCisJICAg ICAgICAgICAgIGZ1bmN0aW9uIGNhbGwuICAqLworCQkgIGVjcy0+ZXZlbnRf dGhyZWFkLT5zdGVwcGluZ19vdmVyX2JyZWFrcG9pbnQgPSAxOworCQl9CisJ ICAgIH0KKwkgIGVsc2UKKwkgICAgeworCSAgICAgIC8qIFNldCB1cCBhIHN0 ZXAtcmVzdW1lIGJyZWFrcG9pbnQgYXQgdGhlIGFkZHJlc3MKKwkgICAgICAg ICBpbmRpY2F0ZWQgYnkgU0tJUF9TT0xJQl9SRVNPTFZFUi4gICovCisJICAg ICAgaW5pdF9zYWwgKCZzcl9zYWwpOworCSAgICAgIHNyX3NhbC5wYyA9IHBj X2FmdGVyX3Jlc29sdmVyOwogCi0JICBpbnNlcnRfc3RlcF9yZXN1bWVfYnJl YWtwb2ludF9hdF9zYWwgKHNyX3NhbCwgbnVsbF9mcmFtZV9pZCk7CisJICAg ICAgaW5zZXJ0X3N0ZXBfcmVzdW1lX2JyZWFrcG9pbnRfYXRfc2FsIChzcl9z YWwsIG51bGxfZnJhbWVfaWQpOworCSAgICB9CiAJfQogCiAgICAgICBrZWVw X2dvaW5nIChlY3MpOwo= --001485f01d609de11004641caba5--