[multiprocess PING] Three patches for focus_command and linux-nat target

[multiprocess PING] Three patches for focus_command and linux-nat target

[teawater]

Hi,

Sorry to disturb you.
Could you please help me review these patches for multiprocess branch
or give me some advices for it?

http://sourceware.org/ml/gdb-patches/2008-11/msg00713.html
This one is for memory leak of focus_command.

http://sourceware.org/ml/gdb-patches/2008-12/msg00001.html
http://sourceware.org/ml/gdb-patches/2008-12/msg00058.html
These ones is for linux-nat target.

Thanks,
Hui

Re: [multiprocess PING] Three patches for focus_command and linux-nat target

[Pedro Alves]

On Wednesday 10 December 2008 03:11:28, teawater wrote:
> Sorry to disturb you.

Sorry, I've been caught up with other things.

> Could you please help me review these patches for multiprocess branch
> or give me some advices for it?
> 
> http://sourceware.org/ml/gdb-patches/2008-11/msg00713.html
> This one is for memory leak of focus_command.

This bit is Stan's code, but it looks OK to me.

> 
> http://sourceware.org/ml/gdb-patches/2008-12/msg00001.html

This is really going in the wrong direction, and probably makes the
checkpoints.exp, multi-forks.exp etc. tests bomb out even more.
If you can be a bit more patient, I'm trying to find time to clean up
a bunch of patches I have here that add proper multi-process support
to the native linux target.

> http://sourceware.org/ml/gdb-patches/2008-12/msg00058.html
> These ones is for linux-nat target.

I'd really like to not extend this hack further.  The caller
upstack should have switched inferior_ptid itself, and if
this is a memory read, trying to read off a proto-inferior, well,
we have to decide how to handle it, patches/proposals/questions
comming as soon as I find a bit of time.

-- 
Pedro Alves