From: teawater <teawater@gmail.com>
To: "Jan Kratochvil" <jan.kratochvil@redhat.com>
Cc: "Thiago Jung Bauermann" <bauerman@br.ibm.com>,
gdb-patches@sourceware.org
Subject: Re: [patch]: Fix memory leak of c-exp.y
Date: Wed, 25 Jun 2008 12:32:00 -0000 [thread overview]
Message-ID: <daef60380806241839v6865bd3g4a3b503d2054f762@mail.gmail.com> (raw)
In-Reply-To: <20080624133540.GA1948@host0.dyn.jankratochvil.net>
On Tue, Jun 24, 2008 at 21:35, Jan Kratochvil <jan.kratochvil@redhat.com> wrote:
> On Tue, 24 Jun 2008 08:32:44 +0200, teawater wrote:
>> ChangeLog:
>> 2008-06-21 Hui Zhu <teawater@gmail.com>
>> * gdb/c-exp.y: Fix memory leak of function parse_number
>
> Agreed with the fix just IMO the block of code needs more cleanups. [attached]
> The leak was brought in by:
> http://sourceware.org/ml/gdb-patches/2007-10/msg00395.html
>
> Just please check the GNU Coding Standards document for the ChangeLog style, it
> should have been more like:
>
> 2008-06-21 Hui Zhu <teawater@gmail.com>
>
> * c-exp.y (parse_number): Fix a memory leak.
>
OK. Thank you Jan.
Hui
next prev parent reply other threads:[~2008-06-25 1:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 12:32 teawater
2008-06-24 14:04 ` Jan Kratochvil
2008-06-25 12:32 ` teawater [this message]
2008-06-25 13:11 ` Joel Brobecker
2008-06-25 13:40 ` Daniel Jacobowitz
-- strict thread matches above, loose matches on Subject: below --
2008-06-21 17:21 teawater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daef60380806241839v6865bd3g4a3b503d2054f762@mail.gmail.com \
--to=teawater@gmail.com \
--cc=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox