Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: teawater <teawater@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch]: Fix memory leak of c-exp.y
Date: Wed, 25 Jun 2008 13:11:00 -0000	[thread overview]
Message-ID: <20080625124303.GB3700@adacore.com> (raw)
In-Reply-To: <daef60380806232332n429917efu4eec3c7ca1731987@mail.gmail.com>

Hi teawater,

> 2008-06-21  Hui Zhu <teawater@gmail.com>
>        * gdb/c-exp.y: Fix memory leak of function parse_number

Instead of adding calls to free, I looks like this string is actually
completely local, so how about replacing the call to malloc with a
call to alloca, and then get rid of all calls to free instead?

-- 
Joel


  parent reply	other threads:[~2008-06-25 12:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-24 12:32 teawater
2008-06-24 14:04 ` Jan Kratochvil
2008-06-25 12:32   ` teawater
2008-06-25 13:11 ` Joel Brobecker [this message]
2008-06-25 13:40   ` Daniel Jacobowitz
  -- strict thread matches above, loose matches on Subject: below --
2008-06-21 17:21 teawater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080625124303.GB3700@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox