From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17698 invoked by alias); 25 Jun 2008 01:40:28 -0000 Received: (qmail 17690 invoked by uid 22791); 25 Jun 2008 01:40:28 -0000 X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.184) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 25 Jun 2008 01:40:02 +0000 Received: by ti-out-0910.google.com with SMTP id d10so1415543tib.12 for ; Tue, 24 Jun 2008 18:39:59 -0700 (PDT) Received: by 10.110.3.15 with SMTP id 15mr7674655tic.10.1214357999881; Tue, 24 Jun 2008 18:39:59 -0700 (PDT) Received: by 10.110.109.4 with HTTP; Tue, 24 Jun 2008 18:39:59 -0700 (PDT) Message-ID: Date: Wed, 25 Jun 2008 12:32:00 -0000 From: teawater To: "Jan Kratochvil" Subject: Re: [patch]: Fix memory leak of c-exp.y Cc: "Thiago Jung Bauermann" , gdb-patches@sourceware.org In-Reply-To: <20080624133540.GA1948@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080624133540.GA1948@host0.dyn.jankratochvil.net> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00422.txt.bz2 On Tue, Jun 24, 2008 at 21:35, Jan Kratochvil wrote: > On Tue, 24 Jun 2008 08:32:44 +0200, teawater wrote: >> ChangeLog: >> 2008-06-21 Hui Zhu >> * gdb/c-exp.y: Fix memory leak of function parse_number > > Agreed with the fix just IMO the block of code needs more cleanups. [attached] > The leak was brought in by: > http://sourceware.org/ml/gdb-patches/2007-10/msg00395.html > > Just please check the GNU Coding Standards document for the ChangeLog style, it > should have been more like: > > 2008-06-21 Hui Zhu > > * c-exp.y (parse_number): Fix a memory leak. > OK. Thank you Jan. Hui